Repository navigation
Docs: DXF export of a non-circular ellipse is listed as a native ELLIPSE - #7420
Merged
Merged
Conversation
The DXF SPLINE line in docs/target-app-parity.md said a non-circular ellipse keeps the existing fallback. crates/cad/src/scene.rs writes a closed four-cubic ellipse, or a circle scaled out of proportion, as a native ELLIPSE in R13 and later, unless its minor-to-major ratio is below 1e-6, and only R12 keeps the fallback. The line now says so.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 14, 2026
Member
|
Merged, thanks @dotCooCoo! It passed its CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The DXF SPLINE line in
docs/target-app-parity.mdsaid that a non-circular ellipse keeps the existing fallback. Since #4841,crates/cad/src/scene.rswrites a closed four-cubic ellipse, or a circle scaled out of proportion, as a nativeELLIPSEin R13 and later, and only R12 keeps the fallback. An ellipse whose minor-to-major ratio is below 1e-6 is still written as a polyline or spline. The line now says so, asdocs/gaps.mdalready does since #6801. No code changed.How it was tested
The new text was checked against
ellipticalincrates/cad/src/scene.rsand the testsellipses_and_unevenly_scaled_circles_are_native_ellipsesandclosed_four_cubic_shapes_that_are_not_writable_ellipses_stay_splinesincrates/cad/src/tests.rs.One commit on
mainat1e4e3534f:git diff --check: no whitespace errors.cargo xtask ciruns in this pull request's CI.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.