[yoriswind]

Landing dependency: #7453. Keep this PR pending until #7453 lands, or land the two changes together. The highlight alone exposes stale guide selection after a plain guide → shape row click. Reproduction discussion.

Clicking a ruler guide in Layers selected the guide, but its row lost its background highlight when the pointer moved away. Use the existing selected-row color while the guide is selected, keeping the hover fill for unselected editable guides.

Guide selection, movement, visibility, locking and deletion stay unchanged. The regression checks the painted background after the pointer leaves, with unselected-guide and ordinary-row controls. Progress notes retain the existing scores and estimates.

Fixes #7344.

Validation: five focused Layers guide tests passed, strict all-target Clippy for vectorcraft-ui-egui completed successfully, and formatting passed.

Summary by CodeRabbit

• Bug Fixes
  • Selected guide rows now remain highlighted when the pointer moves away. Unselected guides show a hover highlight only when editable.
• Documentation
  • Updated UI parity and roadmap documentation to reflect the guide-row highlighting behavior.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Guide rows now show selected-row highlighting after the pointer leaves. Hover highlighting applies only to editable, hovered guides that are not selected. A regression test checks guide-row selection and ordinary row highlighting. Documentation records the update.

Changes: Guide row highlighting

Layer / File(s)	Summary
Render and document selected guide-row highlighting crates/ui-egui/src/panels/layers/rows.rs, crates/ui-egui/src/panels/layers/tests.rs, docs/gaps.md, docs/roadmap.md, docs/target-app-parity.md, docs/ui-parity.md	Selected guide rows use the selected-row fill. Hover fill applies only to editable, hovered, unselected guides. The regression test checks guide and ordinary row highlighting. The documentation records the update and states that guide selection commands, dragging, and deletion remain unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: aiongg, bflatastic

Merge Risk: Minimal · up to 93263

Selected guide rows in the Layers panel now stay highlighted after the pointer leaves, while hover highlighting still applies to unselected editable guides. No concrete defect was found, and the change is low-risk to merge.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: selected guide rows in the Layers panel keep their highlight after the pointer leaves. The changeset matches this: rows.rs picks the selected fill for selected guides,…
Linked Issues check		Issue #7344 requires a selected ruler-guide row to stay highlighted like other selected rows after the pointer leaves. At the reviewed head, guide_row in crates/ui-egui/src/panels/layers/rows.rs n…
Out of Scope Changes check		The code change is limited to guide_row in rows.rs (+3/-1 lines). This directly implements #7344. The test addition in tests.rs supports that change as regression coverage. The documentation edi…
Description check		The description supplies a clear what-and-why: a selected ruler-guide row loses its highlight when the pointer leaves, and the change keeps the selected-row color while the guide stays selected, with …

Full details: Title check

Explanation

The title names the main change: selected guide rows in the Layers panel keep their highlight after the pointer leaves. The changeset matches this: rows.rs picks the selected fill for selected guides, and tests.rs adds a regression test for it.

Full details: Linked Issues check

Explanation

Issue #7344 requires a selected ruler-guide row to stay highlighted like other selected rows after the pointer leaves. At the reviewed head, guide_row in crates/ui-egui/src/panels/layers/rows.rs now paints t.row_selected when view.guides.contains(&i). It paints the hover fill only when the guide is not selected, editable, and hovered. This directly removes the reported behavior: the selected guide keeps its highlight after the pointer moves away. The change does not alter guide selection, movement, visibility, locking, or deletion logic, which the issue does not require to change. The PR summary reports a regression test, guide_row_highlight_stays_selected_without_hover, that covers this case. I could not read crates/ui-egui/src/panels/layers/tests.rs because its blobs were unavailable, so I did not verify that test directly. The issue does not request a specific test, so this does not block the verdict.

Full details: Out of Scope Changes check

Explanation

The code change is limited to guide_row in rows.rs (+3/-1 lines). This directly implements #7344. The test addition in tests.rs supports that change as regression coverage. The documentation edits in docs/gaps.md, docs/roadmap.md, docs/target-app-parity.md, and docs/ui-parity.md only record this same guide-row highlight change. Per the PR description and the parity docs, they keep existing scores and estimates unchanged. The roadmap M1 status line is a status note for this same change, not unrelated work. I did not read the test or docs diffs directly, so the scope of those edits rests on the supplied summary. No unrelated code change is demonstrated.

Full details: Description check

Explanation

The description supplies a clear what-and-why: a selected ruler-guide row loses its highlight when the pointer leaves, and the change keeps the selected-row color while the guide stays selected, with the hover fill kept for unselected editable guides. It links issue #7344 and states that guide selection, movement, visibility, locking and deletion are unchanged. The testing section lists the regression check, the five focused Layers guide tests, a strict Clippy run and formatting. It also contains a landing dependency on #7453. The template's checklist is not reproduced: it has no checkbox for the CI run, the no-panic rule, clean-room provenance, or the ASSETS.md requirement. The author does not say whether these were verified, although the summary says no new assets are added.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: storytold/vectorcraft
• Branch: main
• File: .coderabbit.yaml
• Commit: 9fcfc81
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3d704849-b595-4a93-894e-5217d873cd2c

Commits

Reviewing files that changed from the base of the PR and between 9fcfc81 and 932636e.

Files selected for processing: 6

• crates/ui-egui/src/panels/layers/rows.rs
• crates/ui-egui/src/panels/layers/tests.rs
• docs/gaps.md
• docs/roadmap.md
• docs/target-app-parity.md
• docs/ui-parity.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[yoriswind]

Could a maintainer approve the CI, SonarCloud and Affinity 3 corpus runs for 932636e4e? All three are waiting for approval, with no jobs run yet.