[dotCooCoo]

What and why

Brazilian Portuguese is in COMPLETE_MESSAGES (crates/ui-egui/src/i18n/tests.rs), but on main at 0b29b2b1f6, 1,851 status and error messages that the untranslated report scans had no pt-br row, counting the ones it lists under "every language". With the interface in Brazilian Portuguese, those messages showed in English.

• crates/ui-egui/src/i18n/pt-br.tsv gains 1,812 @msg rows. Existing rows are unchanged.
• The translations are VectorCraft's own, written from the meaning of the English messages, and have had no native-speaker review. They use the catalog's existing terms (prancheta, camada, amostra, caminho, traçado, preenchimento and others). For feature names the new rows follow the catalog's label rows, such as Rastreamento de Imagem, Pintura ao Vivo and Deslocar Caminho, where some older message rows use other wording. Placeholders, backticked parameter names, command ids, double-quoted values and bare true, false and null are kept exactly as the English writes them.
• The 39 rows that open i18n: translate the composite font errors in the complete-message languages #7211, i18n: the "select a path" reason is translated in every complete-message language #7214, i18n: the justification order error is translated in every complete catalog #7116 and Blob Brush: path.blob rejects invalid fidelity, angle and roundness #7330 add are left out, so the catalogs stay consistent when they merge (bundled_catalogs_are_consistent rejects a second row for the same key).
• The Portuguese row of docs/localization-parity.md now gives the catalog's counts: 9,260 rows, 3,445 of them @msg and 48 @msgplural. The "How it is measured" sentence no longer names the commit the old Portuguese count was taken on.

Three of the 1,812 rows are in the file and are counted by the report, but do not yet put their message into Portuguese:

• Template::parse in crates/ui-egui/src/i18n/catalog.rs returns None for a message with two placeholders in a row, so the catalog does not load the rows for unknown parameter `{within}{key}`; {why} and {name} must be {lo}–{hi}{unit} (got {v}).
• The row for {k} has control characters{_1} does not match the message for a multi-line File Info field. Its last placeholder is empty there (crates/engine/src/cmd/fileinfo.rs), and the last placeholder of a row never matches empty text.

How it was tested

No new test: the change adds catalog rows only. bundled_catalogs_are_consistent and the other i18n tests check every new row for TSV parsing, duplicate keys, placeholder agreement, kept parameter names, backticked values and command ids. One of them found a duplicate in a first draft: not an RTF file: it doesn't start with {\rtf already has a pt-br row, written with the catalog's \\ escape, and the second row was removed.

Untranslated report (cargo test -p vectorcraft-ui-egui --lib i18n -- --nocapture):

• Before, on main at 0b29b2b1f6: 1,851 pt-br messages missing (1,405 under "pt-br" and 446 under "every language"); 43,084 missing rows in all.
• On the head d358baf9cc: 39 pt-br messages missing (3 under "pt-br" and 36 under "every language"), all of them the rows left out for i18n: translate the composite font errors in the complete-message languages #7211, i18n: the "select a path" reason is translated in every complete-message language #7214, i18n: the justification order error is translated in every complete catalog #7116 and Blob Brush: path.blob rejects invalid fidelity, angle and roundness #7330; 41,272 missing rows in all.

Focused checks on Linux. The branch is one commit on main at 0b29b2b1f6 and merges cleanly with it. It conflicts with open #7307 in docs/localization-parity.md.

• cargo fmt --all -- --check
• cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings
• cargo check --workspace --tests
• cargo test -p vectorcraft-ui-egui --lib i18n: 110 passed, 0 failed, on the head d358baf9cc.
• cargo xtask brands, layers (30 crates) and assets (337 files).
• cargo xtask ci runs in this pull request's CI.

Checklist

• cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm).
• No panics in shipped code: no unwrap(), expect(), panic!, unreachable!, todo! or
  unimplemented! outside tests, and no unchecked indexing on data from files, parameters or
  messages. Errors are returned as Result and shown to the user
  (why and how).
• Clean-room: nothing copied from Adobe products or GPL/AGPL code (AGENTS.md).
• Every new asset has a row in ASSETS.md.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: storytold/vectorcraft
• Branch: main
• File: .coderabbit.yaml
• Commit: 0b29b2b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6968c961-ceaf-4a56-9d0e-9d7d3bdca619

Commits

Reviewing files that changed from the base of the PR and between 0b29b2b and d358baf.

Files ignored due to path filters: 1

• crates/ui-egui/src/i18n/pt-br.tsv is excluded by !**/*.tsv

Files selected for processing: 1

• docs/localization-parity.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[bflatastic]

Merged, thanks @dotCooCoo! It passed its CI checks.