Conversation
fpistm
requested changes
Apr 5, 2023
fpistm
left a comment
fpistm
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR. In fact you add the generic mcu support not the specific DK board.
README.md file have to be updated to reference new mcu declaration..
| # See: https://github.com/stm32duino/Arduino_Core_STM32/wiki/Add-a-new-variant-%28board%29 | ||
|
|
||
| # Generic C011D6Yx | ||
|
|
Member
There was a problem hiding this comment.
This file must not be changed, it is generated automatically. It is used to ease addition in the boards.txt.
All generic should be added in the boards.txt.
Member
|
Superseded by #2049 |
fpistm
added
duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following features:
Motivation: these are new architectures / dev boards that ST seems to push for.
Let me know if there's anything that can be improved :)