Skip to content

fix exception raised on invalid lud06 - #271

Merged
michaelhall923 merged 1 commit into
mainfrom
bndw/fix-zappable-exception
Aug 29, 2023
Merged

fix exception raised on invalid lud06#271
michaelhall923 merged 1 commit into
mainfrom
bndw/fix-zappable-exception

Conversation

@bndw

@bndw bndw commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

ndk is throwing an exception in getZapEndpoint when it calls bech32.decode with invalid data (in this case "zero").

This hotfix simply wraps the operation it a try block.

image

@vercel

vercel Bot commented Aug 29, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stemstr-client ❌ Failed (Inspect) Aug 29, 2023 6:53pm

Comment thread components/NoteActionZap/NoteActionZap.tsx Outdated
@bndw
bndw force-pushed the bndw/fix-zappable-exception branch from 0a1aefb to 94f2d86 Compare August 29, 2023 18:49
@michaelhall923
michaelhall923 merged commit cca0b72 into main Aug 29, 2023
@bndw bndw mentioned this pull request Aug 29, 2023
@bndw
bndw deleted the bndw/fix-zappable-exception branch August 29, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants