JH7110_VisionFive2_devel: jh7110.dtsi has wrong U-Boot fwenv data pointer

At https://doc-en.rvspace.org/VisionFive2/Boot_UG/JH7110_SDK/boot_address_allocation.html
I find that in 16M QSPI, I can reach U-Boot fw env block by reading from

0xF0000	0x10000	U-Boot environment variables

Now,

linux/arch/riscv/boot/dts/starfive/jh7110.dtsi

Line 374 in 4639179

data@f00000 {

shows that offset is invalid - it was mistyped and contains extra 0. It shall be defined as:

	data@f0000 {
		reg = <0xf0000 0x10000>;
	};

With this, fw_printenv from Linux succeeds, I can see/edit U-Boot config.

My proposal would also be to define whole QSPI flash:

    partitions {
            compatible = "fixed-partitions";
            #address-cells = <0x01>;    
            #size-cells = <0x01>;       

            spl@0 {
                    reg = <0x00 0x20000>;       
            };

            env@f0000 {
                    reg = <0xf0000 0x10000>;    
            };

            uboot@100000 {
                    reg = <0x100000 0x400000>;  
            };

            bootdata@500000 {           
                    reg = <0x500000 0xb00000>;  
            };

            flashall@0 {
                    reg = <0x00 0x1000000>;     
            };
    };

Especially with flashall, I can read/write whole QSPI if desired.

Please review this. Thank you.

Just linking the related discussion here: https://forum.rvspace.org/t/emmc-boot-though-spi-flash/1320

Fix zswap and U-Boot env mtd device

Works perfectly. @electrorys would you mind to open a pull request for this change? At the moment there seems to be no activity regarding reviewing and merging pull requests, probably they are concentrating on mainline integration. However, it cannot hurt.

I'd keep it the minimal correction for now. While it makes generally sense IMO to add all addresses, I'd leave the environment at mtd2 (even that it does not match its logical location after SPL but before U-Boot image), so current guides/instructions floating around and possible existing configs don't get broken.

Fix zswap and U-Boot env mtd device

Hi,

Meh it really took me two days of RTFM to learn how to make my first PR ever. You know, I don't have good git-fu :-)
Please review #91

😄, hopefully you and/or the open source community will benefit from this learning curve. As said

I'd keep it the minimal correction for now.

i.e. the typo correction only, to maximise the chance that it gets merged soon. Then adding the additional areas in a second PR, as this is a matter of discussion, especially when device names change and hence currently published instructions about how to update the bootloader break.

Thanks, I hope aswell 💯
Now you can do whatever you want with it, I don't mind, hopefully this PR will be helpful!

Now you can do whatever you want with it

Just to avoid misunderstanding, I'm not related in any way with StarFive. I just saw your issue here, the related discussion on the rvspace forum, tested data@f00000 => data@f0000 and can verify it is working and without doubt a mandatory bug fix.

So I am not doing anything with this PR, but StarFive are the ones who have to decide whether/what to do with it.

I'm not sure how much efforts StarFive put into reviewing and in case adjusting PRs, so my suggestion to keep it minimal was to eliminate any points which may require discussion and any needs to edit the PR, hence minimising required efforts to merge it and maximising the chance that it will be merged 😉.

Got it, indeed I was falsely impressed that you're affiliated with them. 26 марта 2023 г. 15:55:28 UTC, MichaIng ***@***.***> пишет:

…

> Now you can do whatever you want with it Just to avoid misunderstanding, I'm not related in any way with StarFive. I just saw your issue here, the related discussion on the rvspace forum, tested ***@***.***` => ***@***.***` and can verify it is working and without doubt a mandatory bug fix. So I am not doing anything with this PR, but StarFive are the ones who have to decide whether/what to do with it. I'm not sure how much efforts StarFive put into reviewing and in case adjusting PRs, so my suggestion to keep it minimal was to eliminate any points which may require discussion and any needs to edit the PR, hence minimising required efforts to merge it and maximising the chance that it will be merged 😉. -- Reply to this email directly or view it on GitHub: #81 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

Fix zswap and U-Boot env mtd device

bpftool: Fix missing pids during link show

Fix zswap and U-Boot env mtd device

Navigation Menu

Repository navigation

JH7110_VisionFive2_devel: jh7110.dtsi has wrong U-Boot fwenv data pointer #81

28 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

JH7110_VisionFive2_devel: jh7110.dtsi has wrong U-Boot fwenv data pointer #81

Description

Activity

MichaIng commented on Mar 15, 2023

MichaIng commented on Mar 22, 2023

strlcat commented on Mar 25, 2023

MichaIng commented on Mar 25, 2023

strlcat commented on Mar 26, 2023

MichaIng commented on Mar 26, 2023

strlcat commented on Mar 26, 2023

28 remaining items

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions