Repository navigation
Fix field names in external-auth examples - #6330
Merged
ChrisJBurns merged 2 commits intoOct 20, 2026
Merged
Conversation
The example manifests under examples/operator/external-auth/ used snake_case keys (token_url, client_id, client_secret_ref, external_token_header_name) where the CRD schema expects camelCase (tokenUrl, clientId, clientSecretRef, externalTokenHeaderName), and a "scope" string where the schema defines a "scopes" list — so applying them verbatim fails validation. Update the manifests to match the schema. Signed-off-by: Enes Deniz <142517728+3nesdeniz@users.noreply.github.com>
3 of 5 tasks
ChrisJBurns
approved these changes
Oct 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6330 +/- ##
==========================================
- Coverage 79.76% 79.75% -0.02%
==========================================
Files 825 825
Lines 84263 84268 +5
==========================================
- Hits 67212 67207 -5
- Misses 17046 17056 +10
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example manifests under
examples/operator/external-auth/use snake_case keys (token_url,client_id,client_secret_ref,external_token_header_name) where the CRD schema expects camelCase (tokenUrl,clientId,clientSecretRef,externalTokenHeaderName), and ascopestring where the schema defines ascopeslist — so applying them verbatim fails validation. This updates the manifests to match the schema.Split out of #6242 per review, so it can land on its own merits.
Validation
kubectl apply --dry-run=serverrequires a cluster with the CRDs installed; verified instead that every changed key matches the generated schema indeploy/charts/operator-crds/files/crds/toolhive.stacklok.dev_mcpexternalauthconfigs.yaml.