Synchronise master with upstream - #113
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
The plugin's enabled file sets AUTO_DISCOVER_STATIC_FILES = True, so django-compressor bundles grouping.js into Horizon's global script bundle, executed on every page. Its top-level JSON.parse of the groupby_list_config json_script element throws a TypeError on every non-CloudKitty page, aborting the bundle mid-file: angular.module() registrations after the abort point never run and Angular bootstrap fails with [$injector:modulerr] — every Angular panel in Horizon (Images, Key Pairs, Server Groups, ...) breaks cloud-wide, with no failed network request to hint at the cause. Guard the whole body on the element's existence. Block scoping the const/class declarations also fixes the redeclaration SyntaxError from the file being executed twice on CloudKitty's own pages (global bundle plus the template's explicit script tag). Closes-Bug: #2160103 Change-Id: I556b77996f09b0259cb9fcc5b1e6ba53d5bcf68c Signed-off-by: Mahmoud Abouzeid <abouzeid@momentumx.cloud>
github-actions
Bot
added
automated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.