Link ICU data (small or full) on Windows. Also need to fixup the Unixy build again. - #2
Merged
Merged
Conversation
doing it wrong, via git
Code is able to build a complete ICU now.
needed for manifest rebuild of ICU data
also update docs still very much based on version number and a "special ICU branch".
srl295
added a commit
that referenced
this pull request
Jun 24, 2014
build: i18n: This adds icu-small and icu-full options to the vcbuild.bat script. note README.md updated about dependencies.
Owner
Author
|
this is in support of this PR: nodejs#7719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: i18n: This adds
icu-smallandicu-fulloptions to the vcbuild.bat script. noteREADME.mdabout dependencies.