Skip to content

Disable Lowercase HTTP Method Firewall Test #19541

Description

@jzheaux

Since Spring Framework's HttpMethod#valueOf now performs a case-insensitive
lookup (spring-framework#36518), HttpMethod.valueOf("get") resolves to
HttpMethod.GET instead of a distinct non-canonical value.

As a result, StrictServerWebExchangeFirewallTests#getFirewalledExchangeWhenLowercaseGetThenThrowsServerExchangeRejectedException
no longer holds: a lowercase get request is no longer distinguishable as
non-canonical case by the time it reaches the firewall, so it is processed
as an ordinary GET instead of being rejected.

This test has been disabled since the behavior it asserts is no longer
possible upstream. The team should confirm whether to remove it outright, or
repurpose it to document that a customized ServerExchangeRejectedHandler
is no longer invoked for this case.

Related to #19528.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)type: taskA general task

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions