fix(deps): bump starlette to 1.3.1 for VULN-88813 - #143
Conversation
Code Review — AI-Assisted Feedback
Verdict: Approve with commentsMinimal (2 files), well-scoped CVE fix. Major-version starlette jump and dev fastapi bump are both necessary and CI-verified — two documentation nits below. P3 — Major-version starlette jump (0.x → 1.x) affects optional-extra consumers (Claude Code)File/Section: P3 — Dev fastapi bump silently forces pydantic >=2.9.0 on contributors (Claude Code)File/Section:
|
Pin starlette >=1.3.1 (optional dep) and bump dev fastapi to ^0.135.0 to resolve DoS in request.form() urlencoded body handling. Document Starlette 0.x→1.x breaking change and pydantic v2 dev requirement. Co-authored-by: Cursor <cursoragent@cursor.com>
95b6942 to
f0d0b9f
Compare
Summary
request.form()urlencoded bodies ignoredmax_fields/max_part_size(fixed in 1.3.1).starlettefloor to>=1.3.1; bump devfastapito^0.135.0to drop the<0.47Starlette cap.Notes
middleware/openai/crewaiextras (mcp/sse-starlette).<0.47.Test plan
poetry checkpoetry run pytest tests/(1995 passed, 4 skipped)Jira
VULN-88813