Repository navigation
charliecloud: require squashfuse 0.4.0 or newer for 0.44 and later - #7083
Merged
cmelone merged 1 commit intoNov 11, 2026
Merged
Conversation
Charliecloud 0.44 enabled multi-threaded FUSE, which the Charliecloud maintainers report older SquashFUSE seems not to support well. Keep the existing 0.1.105:0.2.0,0.4.0: range for 0.36 through 0.43 and require squashfuse@0.4.0: from 0.44 on. Fixes spack#5400
Contributor
Author
|
@j-ogas @reidpr, the |
j-ogas
approved these changes
Oct 28, 2026
j-ogas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks, and sorry for the delayed response.
cmelone
approved these changes
Nov 11, 2026
cmelone
enabled auto-merge (squash)
November 11, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5400.
Why
In #5400, @reidpr (a Charliecloud maintainer) reports that Charliecloud 0.44 enabled multi-threaded FUSE and that older SquashFUSE seems not to support it well; I have not tested that myself, and this change follows his read. The package currently allows
squashfuse@0.1.105:0.2.0,0.4.0:for every version from 0.36 on, so today a 0.44 build against SquashFUSE 0.2.0 concretizes without complaint. Upstream's own install docs moved the floor between releases: the 0.44 install page still says "SquashFUSE v0.1.105 or later, excluding v0.3.0", while the 0.45 and main pages say "SquashFUSE v0.4.0 or later".What changed
One file,
repos/spack_repo/builtin/packages/charliecloud/package.py, insidewith when("+squashfuse")::squashfuse@0.1.105:0.2.0,0.4.0:rule is capped towhen="@0.36:0.43";depends_on("squashfuse@0.4.0:", type="link", when="@0.44:")follows it, with a three-line comment pointing at charliecloud: update SquashFUSE dependency #5400.Versions 0.36 to 0.43 keep the range they had, since the issue names 0.44 as the first affected release. The 0.35 line and the configure arguments are untouched.
Checks
Run in a Linux container (spack 1.3.0.dev0, this repo at f469a0b plus this diff; charliecloud has
conflicts("platform=darwin"), so I could not run these on macOS). Spec output is trimmed to the charliecloud and squashfuse lines.Before, on develop:
After, on this branch:
The
@mainerror message blamescharliecloud@mainrather than the squashfuse rule, so on its own it is not proof; read with the before run (main accepted 0.2.0, exit 0) and themain ^squashfuse@0.4.0run (exit 0), it showsmainnow sits under the@0.44:rule, which is what I expect since Spack treats branch versions as newest.Repo checks on the branch:
Note
If you would rather tighten the whole
@0.36:range instead of splitting at 0.44, I can change it; I kept the split because the issue only names 0.44 and up. This is my first PR here and I am doing it as part of a course; I used Claude as a coding assistant for the checks and drafting, and the change and this text are mine.