src validation for ebs-csi drivers and VPCs - #939
Merged
Conversation
jasonhawkharris
changed the title
jasonhawkharris
marked this pull request as draft
February 16, 2023 22:30
jasonhawkharris
marked this pull request as ready for review
February 17, 2023 17:29
jasonhawkharris
marked this pull request as draft
February 21, 2023 17:56
jdpleiness
suggested changes
Feb 22, 2023
jdpleiness
left a comment
jdpleiness
left a comment
Contributor
There was a problem hiding this comment.
This looks great overall! I think it's going to be really helpful as well 🚀
jasonhawkharris
force-pushed
the
jhh/kube-feature
branch
from
February 22, 2023 22:23
6412338 to
eb6ddb1
Compare
- Before, validation ran regardless of whether current kubectl context was set to an EKS cluster or not - Now, if --eks flag is added to the command, src checks that an EKS cluster is already configured
jasonhawkharris
force-pushed
the
jhh/kube-feature
branch
from
February 23, 2023 17:24
6ec4c18 to
19ae11a
Compare
jasonhawkharris
marked this pull request as ready for review
February 23, 2023 17:29
jac
reviewed
Feb 24, 2023
Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com>
jdpleiness
approved these changes
Feb 24, 2023
jdpleiness
left a comment
jdpleiness
left a comment
Contributor
There was a problem hiding this comment.
This is looking really nice! Just a few suggestions, otherwise LGTM 🚀
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
jasonhawkharris
force-pushed
the
jhh/kube-feature
branch
from
February 24, 2023 21:27
da274f5 to
af91e35
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* validate ebs-csi drivers on EKS clusters * add condition for failed config * add validation for vpcs * Adds tests for validate VPC * formatting, add comment for EksVpc * fix formatting in kube test * add test for ebs-csi validation and refactor * formatting * remove commented out function signature * checks current context when using --eks flag - Before, validation ran regardless of whether current kubectl context was set to an EKS cluster or not - Now, if --eks flag is added to the command, src checks that an EKS cluster is already configured * formatting * fix ineffectual append that linter flagged * refactor * formatting * retab * Adds more robust testing for ebs csi drivers * remove test copies from kube_test * formatting * retab * add tests and refactor * improve naming conventions to be less confusing and more informative * Update internal/validate/kube/kube.go Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com> * retab * more retabbing * Update internal/validate/kube/eks.go Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com> * Moved/renamed Eks() function to eks file * formatting --------- Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr> Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com> Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
ebs-csidrivers on AWS EKS clusters andTest plan
Shipped with test suite