batches: query max unlicensed changesets count - #929
Conversation
1da7217 to
41ab46f
Compare
41ab46f to
861cbaf
Compare
courier-new
left a comment
courier-new
left a comment
There was a problem hiding this comment.
Approach looks really solid to me! Sorry my review is basically a million nits to improve code quality a bit, but hopefully they make it easier for you to update things. 🙂
Would you mind... (I bet you can guess what I'm about to ask! 😜) ...sharing a screenshot of the new error, too?
@courier-new i asked for a review and then i removed it when i realized i had some mistakes but thank you for your prompt and helpful review! it was like 1am and i was so tired that i couldnt find where to switch it to draft so i removed review instead lol and by the way i love the 'nitpicky' for code quality. Thank you! |
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
adeola-ak
changed the title
courier-new
left a comment
courier-new
left a comment
There was a problem hiding this comment.
Just made a couple suggestions to preserve inline function documentation, otherwise 👍
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
Co-authored-by: Kelli Rockwell <kelli@sourcegraph.com>
replace hardcoded permitted unlicensed changesets count by querying maxUnlicensedChangesets
3 participants
Closes #913
Change the 10 changeset limit for batch changes for unlicensed/free tier Sourcegraph instances from being hardcoded, to querying
maxUnlicensedChangesetin the mutation where we create the batch spec so that error codesErrBatchChangesUnlicensedandErrBatchChangesOverLimitreturns valueTest plan
Test creating a batch change with more changesets than the current
maxUnlicensedChangesetsvalues as an unlicensed user