codeintel: print every error encountered while retrying code-intel upload instead of only final one - #915
Merged
Merged
Conversation
Strum355
marked this pull request as ready for review
January 10, 2023 14:53
Strum355
force-pushed
the
nsc/bump-sg/sg/lib
branch
from
January 10, 2023 14:54
50514b3 to
8b07993
Compare
Strum355
commented
Jan 10, 2023
Comment on lines
-13
to
+17
| * `src validate` has an added check to determine if an instance is able to create a basic code insight. | ||
|
|
||
| ### Added | ||
|
|
||
| - `src validate` has an added check to determine if an instance is able to create a basic code insight. [#912](https://github.com/sourcegraph/src-cli/pull/912) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@mucles I had to fix up a few things with this changelog entry btw
eseliger
approved these changes
Jan 10, 2023
Strum355
enabled auto-merge (squash)
January 10, 2023 15:01
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
…load instead of only final one (#915)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://github.com/sourcegraph/sourcegraph/pull/46281, will bump go.mod when its merged
Test plan
Tested as part of the above linked PR