Skip to content
This repository was archived by the owner on Oct 29, 2021. It is now read-only.
This repository was archived by the owner on Oct 29, 2021. It is now read-only.

Make httptrace.responseInfoRecorder compatible with http.Hijacker #145

Open
Open
Make httptrace.responseInfoRecorder compatible with http.Hijacker#145
Labels
bughelp wanted

Description

@sqs
sqs
opened on Apr 20, 2016

The httptrace server middleware writes to the HTTP response at

appdash/httptrace/server.go

Line 85 in 9dd479d

SetSpanIDHeader(rr.Header(), *spanID)
even if it has been hijacked (with http.Hijacker, for WebSockets for example). This has undefined behavior. It should detect if it has been hijacked and not write to it. Same for Flush.

Activity

  1. sqs
    added
    enhancement
    on Apr 20, 2016
  2. sqs
    changed the title [-]Make httptrace.responseInfoRecorder implement Hijacker[/-] [+]Make httptrace.responseInfoRecorder compatible with http.Hijacker[/+] on Apr 20, 2016
  3. sqs
    added
    bug
    and removed
    enhancement
    on Apr 20, 2016
  4. emidoots
    added
    help wanted
    on Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bughelp wanted

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions