Repository navigation
chore(discord-voice): record turns to conversation.sqlite, drop JSONL writers - #974
Merged
Merged
Conversation
… writers #791 migrated voice + phone session logging to conversation.sqlite but left discord-voice still writing per-session JSONL (discord-voice-*.jsonl) plus discord-voice-metrics.jsonl. This finishes that migration — the piece #791 left undone. discord-voice-server.ts now calls recordConversation / recordSession from src/conversation-store.ts (which already declares 'discord-voice' as a session source); the two JSONL writers and the now-unused logLine/LOG_PATH helper are removed. Closes #792. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nel id Addresses review on #974: - Mirror discord-voice turns into logs/conversation.log alongside the conversation.sqlite write, matching the phone path. Without the text-log copy, `import-conversation-log.py --reload` (which rebuilds the sqlite `conversation` table from conversation.log) would silently drop discord-voice rows. - Encode guild + channel id into the session id so channel-level diagnostics survive into the sessions table (recordSession has no guild/channel field). - SKILL.md: correct the stale "metrics land in JSONL" line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Pushed
On the |
Addresses re-review on #974: - Add discord-voice-server.ts to _LIVE_WRITER_PATTERNS in both import-conversation-log.py and import-session-metrics.py. discord-voice is now a live conversation.sqlite writer, so the --reload live-writer guard must detect it or a reload could race (and drop) its rows. - Write conversation.log before the sqlite mirror so a turn never exists in sqlite without its conversation.log line — matches the primary-log contract the reload importer depends on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Pushed
|
liususan091219
added a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
… writers (sonichi#974) * chore(discord-voice): record turns to conversation.sqlite, drop JSONL writers sonichi#791 migrated voice + phone session logging to conversation.sqlite but left discord-voice still writing per-session JSONL (discord-voice-*.jsonl) plus discord-voice-metrics.jsonl. This finishes that migration — the piece sonichi#791 left undone. discord-voice-server.ts now calls recordConversation / recordSession from src/conversation-store.ts (which already declares 'discord-voice' as a session source); the two JSONL writers and the now-unused logLine/LOG_PATH helper are removed. Closes sonichi#792. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(discord-voice): mirror turns to conversation.log; preserve channel id Addresses review on sonichi#974: - Mirror discord-voice turns into logs/conversation.log alongside the conversation.sqlite write, matching the phone path. Without the text-log copy, `import-conversation-log.py --reload` (which rebuilds the sqlite `conversation` table from conversation.log) would silently drop discord-voice rows. - Encode guild + channel id into the session id so channel-level diagnostics survive into the sessions table (recordSession has no guild/channel field). - SKILL.md: correct the stale "metrics land in JSONL" line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(discord-voice): guard --reload against the discord-voice writer Addresses re-review on sonichi#974: - Add discord-voice-server.ts to _LIVE_WRITER_PATTERNS in both import-conversation-log.py and import-session-metrics.py. discord-voice is now a live conversation.sqlite writer, so the --reload live-writer guard must detect it or a reload could race (and drop) its rows. - Write conversation.log before the sqlite mirror so a turn never exists in sqlite without its conversation.log line — matches the primary-log contract the reload importer depends on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#791 migrated voice + phone session logging to
conversation.sqlitebut left discord-voice still writing per-session JSONL (discord-voice-*.jsonl) plusdiscord-voice-metrics.jsonl. This finishes that migration — the piece #791 left undone.discord-voice-server.tsnow callsrecordConversation/recordSessionfromsrc/conversation-store.ts(which already declares'discord-voice'as a session source).logLine/LOG_PATHhelper are removed.Net:
+8 −28, one file. No behaviour change beyond the logging sink.Closes #792.
Test plan
tsc --noEmitpassesconversation.sqlite; no newdiscord-voice-*.jsonlwritten🤖 Generated with Claude Code