Repository navigation
fix(startup): stop setting git committer.* — it CLA-blocks every fleet PR - #950
Merged
Merged
Conversation
…t PR startup.sh derived `committer.name`/`committer.email` from stand-identity.json so `git log %cn` showed which fleet host (Mini, MacBook…) crafted each commit. The feature comment assumed only the *author* gates CLA-Assistant — but git 2.31+ honors `committer.*` config natively, so the COMMITTER became `<host>@noreply.sutando.local`, a non-GitHub identity with no CLA signature. CLA-Assistant checks BOTH author and committer. Result: every commit from a fleet host failed the CLA gate — PR #947 and others were blocked purely on the committer field, even with a CLA-signed author. Remove the attribution block. Also actively `--unset committer.*` on every startup so hosts that already have the stale config in `.git/config` self-heal on next boot (no manual cleanup needed). Per-host attribution, if still wanted, belongs in a commit-message trailer — CLA-Assistant ignores trailers; it does not ignore the committer identity. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@CLAassistant check |
liususan091219
pushed a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
…t PR (sonichi#950) startup.sh derived `committer.name`/`committer.email` from stand-identity.json so `git log %cn` showed which fleet host (Mini, MacBook…) crafted each commit. The feature comment assumed only the *author* gates CLA-Assistant — but git 2.31+ honors `committer.*` config natively, so the COMMITTER became `<host>@noreply.sutando.local`, a non-GitHub identity with no CLA signature. CLA-Assistant checks BOTH author and committer. Result: every commit from a fleet host failed the CLA gate — PR sonichi#947 and others were blocked purely on the committer field, even with a CLA-signed author. Remove the attribution block. Also actively `--unset committer.*` on every startup so hosts that already have the stale config in `.git/config` self-heal on next boot (no manual cleanup needed). Per-host attribution, if still wanted, belongs in a commit-message trailer — CLA-Assistant ignores trailers; it does not ignore the committer identity. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/startup.shderivedcommitter.name/committer.emailfromstand-identity.jsonon every boot, sogit log %cnwould show which fleet host (Mini, MacBook…) crafted a commit. The block's comment explicitly reasoned that only the author gates CLA-Assistant, so the committer was "free to carry per-host attribution."That reasoning is wrong. git 2.31+ honors
committer.*config natively, so the committer became<host>@noreply.sutando.local— a non-GitHub identity with no CLA signature. CLA-Assistant checks both author and committer.Result: every commit authored on a fleet host failed the CLA gate on the committer field alone, even with a CLA-signed author. PR #947 and others were blocked this way; multiple contributors reported being stuck.
Verified on this machine — commit
54d78a7:Fix
committer.*-setting block fromstartup.sh.--unset committer.name/emailon every startup, so any host that already has the stale keys in.git/configself-heals on next boot — no manual per-host cleanup.After this, committer falls back to
user.*(the CLA-signed GitHub-noreply identity), matching the author.Note
Per-host attribution isn't worth blocking every PR. If it's still wanted, it belongs in a commit-message trailer (CLA-Assistant ignores trailers) — not the committer identity. Out of scope here; this PR just unblocks the gate.
🤖 Generated with Claude Code