[qingyun-wu]

Summary

Extract Mini's per-process mkdtempSync test isolation pattern (established by #849) into a shared helper, eliminating the boilerplate duplication flagged by sonichi-bot on #858 LGTM follow-up.

Before — each test file:

const TEMP_WORKSPACE = mkdtempSync(join(tmpdir(), 'sutando-test-foo-'));
process.env.SUTANDO_WORKSPACE = TEMP_WORKSPACE;
// ...
after(() => rmSync(TEMP_WORKSPACE, { recursive: true, force: true }));

After:

import { setupTempWorkspace } from './_helpers/temp-workspace.js';
const { workspace, cleanup } = setupTempWorkspace('foo');
// ...
after(cleanup);

Changes

• tests/_helpers/temp-workspace.ts — new helper with setupTempWorkspace(name) returning { workspace, cleanup }.
• tests/agent-state-endpoint.test.ts — uses helper, ditches inline mkdtempSync/rmSync boilerplate.
• tests/get-core-status-tool.test.ts — same.
• .gitignore — allowlist tests/_helpers/ (the existing tests/* rule shadowed the new dir).

Test plan

• npx tsc --noEmit — clean.
• npx tsx --test tests/get-core-status-tool.test.ts — all 6 cases pass.
• CI green on tests/agent-state-endpoint.test.ts (spawn-based, slow locally).

Closes #862.

[sonichi]

LGTM. Clean factoring of the per-process temp-workspace pattern that #849 established. Verified locally on commit head:

• tests/_helpers/temp-workspace.ts doc-comment is excellent — explains the module-init vs env-read timing subtlety that bites people (and is the reason setupTempWorkspace writes process.env.SUTANDO_WORKSPACE unconditionally, not just returns the path).
• .gitignore allowlist for tests/_helpers/ is necessary — the existing tests/* rule was shadowing the new dir; without these two lines the helper wouldn't get committed.
• grep -rln "mkdtempSync.*sutando-test" tests/ confirms the 2 migrated files are the only ones using this pattern. No other test file silently kept the boilerplate.
• npx tsc --noEmit clean, npx tsx --test tests/get-core-status-tool.test.ts → 6/6 pass.
• CI green.

Nit (non-blocking, future PR): the helper's spawn-child guidance ("pass SUTANDO_WORKSPACE: workspace in the child's env") could be a tiny convenience overload — setupTempWorkspace('foo', { forChildSpawn: true }) returning { ..., childEnv: { SUTANDO_WORKSPACE: workspace } } — but only worth adding when a third spawn-based test file shows up. Not now.

Ready to merge.