Skip to content

fix(open_url): reuse active tab when target shares origin #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonichi merged 1 commit into from
May 15, 2026
Merged

fix(open_url): reuse active tab when target shares origin #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions src/browser-tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export const closeTabTool: ToolDefinition = {
export const openUrlTool: ToolDefinition = {
name: 'open_url',
description:
'Open a URL in a new Chrome tab. Use for: "open github.com", "go to that link".',
'Open a URL in Chrome. Reuses the active tab when the target shares origin (scheme + host + port) with what\'s already in the active tab; spawns a new tab only for cross-origin URLs. Use for: "open github.com", "go to that link".',
parameters: z.object({
url: z.string().describe('The URL to open'),
}),
Expand All @@ -223,10 +223,32 @@ export const openUrlTool: ToolDefinition = {
const { url } = args as { url: string };
// Escape backslashes first, then quotes — prevents shell injection via osascript
const safeUrl = url.replace(/\\/g, '\\\\').replace(/'/g, "'\\''").replace(/"/g, '\\"');
// Parse target origin (scheme + host + port). If unparseable, fall back to new-tab behavior.
let targetOrigin = '';
try { targetOrigin = new URL(url).origin; } catch { /* not a real URL, e.g. "about:blank" — let Chrome handle */ }
try {
execSync(`osascript -e 'tell application "Google Chrome" to tell front window to make new tab with properties {URL:"${safeUrl}"}'`, { timeout: 5_000 });
console.log(`${ts()} [OpenURL] opened: ${url}`);
return { status: 'opened', url };
// Query active-tab URL to decide reuse vs new-tab. If origin matches, set URL on active
// tab; otherwise open a new tab. Falls back to new-tab on any error so callers never
// silently fail to open the URL.
let reused = false;
if (targetOrigin) {
try {
const activeUrl = execSync(`osascript -e 'tell application "Google Chrome" to get URL of active tab of front window'`, { timeout: 3_000 }).toString().trim();
if (activeUrl) {
let activeOrigin = '';
try { activeOrigin = new URL(activeUrl).origin; } catch {}
if (activeOrigin && activeOrigin === targetOrigin) {
execSync(`osascript -e 'tell application "Google Chrome" to set URL of active tab of front window to "${safeUrl}"'`, { timeout: 5_000 });
reused = true;
}
}
} catch { /* fall through to new-tab */ }
}
if (!reused) {
execSync(`osascript -e 'tell application "Google Chrome" to tell front window to make new tab with properties {URL:"${safeUrl}"}'`, { timeout: 5_000 });
}
console.log(`${ts()} [OpenURL] ${reused ? 'reused active tab' : 'opened new tab'}: ${url}`);
return { status: reused ? 'reused' : 'opened', url };
} catch (err) {
return { error: `Failed to open ${url}: ${err instanceof Error ? err.message : err}` };
}
Expand Down
Loading