Repository navigation
fix(web-client): always emit data-taskid so flash + expand hit working tasks - #686
Merged
Merged
Conversation
…and:N hit working tasks Both renderers (primary line 1150, dynamic-region line 2319) only attached `data-taskid` when `hasResult` was true. For working tasks (no result yet), the wrapper had no data-taskid — so: - the 1s yellow flash from PR #684 silently no-op'd (querySelectorAll `[data-taskid="..."]` matched nothing) - the `.expanded` class still got added to .task-text, but that only widens long titles via `white-space: normal`; short titles looked unchanged Fix: - Always emit `data-taskid` on the .task-item wrapper, in both renderers. - Add `data-clickable="1"` (only when hasResult) as the separate flag the global click handler uses — preserves "working tasks aren't clickable" behavior without coupling it to the flash target. Self-verified via Chrome MCP: - 30/30 .task-item have data-taskid - expand:3 → target's .task-text gets .expanded AND .task-flash applied - Click handler still only fires for clickable items. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
liususan091219
pushed a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
…and:N hit working tasks (sonichi#686) Both renderers (primary line 1150, dynamic-region line 2319) only attached `data-taskid` when `hasResult` was true. For working tasks (no result yet), the wrapper had no data-taskid — so: - the 1s yellow flash from PR sonichi#684 silently no-op'd (querySelectorAll `[data-taskid="..."]` matched nothing) - the `.expanded` class still got added to .task-text, but that only widens long titles via `white-space: normal`; short titles looked unchanged Fix: - Always emit `data-taskid` on the .task-item wrapper, in both renderers. - Add `data-clickable="1"` (only when hasResult) as the separate flag the global click handler uses — preserves "working tasks aren't clickable" behavior without coupling it to the flash target. Self-verified via Chrome MCP: - 30/30 .task-item have data-taskid - expand:3 → target's .task-text gets .expanded AND .task-flash applied - Click handler still only fires for clickable items. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-taskidonly when the task had a result. Working tasks (no result yet) got no data-taskid, so PR feat(task-expand): 1s yellow flash on expand:N target (visible feedback) #684's flash query found nothing and Chi saw "no yellow flash and no expansion".data-clickableattr so click-to-toggle still only fires for result-bearing tasks.Self-verification
document.body.dataset.taskAction = 'expand:3'→ target's.task-textgets.expanded, target gets.task-flash.node --checkon served JS: silent.Test plan
🤖 Generated with Claude Code