Repository navigation
fix(task-num): apply numPrefix to the dynamic-region task list (2nd render path) - #682
Merged
Merged
Conversation
…ender path) #681 only patched the primary renderTasks (line 1148). There's a SECOND renderer in the dynamic-region path (line 2280) for the contextual task list — that's the one Chi was actually looking at. Hence "I see 1. in querySelector but not in UI." DevTools `textContent.slice(0,10)` on the visible list returned '[Discord] ' — no numPrefix — confirming the second path was running. This patch adds the same `var numPrefix = (i + 1) + '. ';` + `displayText = numPrefix + ...` to the second renderer. .map() now passes (entry, i) so i is available.
liususan091219
pushed a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
…ender path) (sonichi#682) sonichi#681 only patched the primary renderTasks (line 1148). There's a SECOND renderer in the dynamic-region path (line 2280) for the contextual task list — that's the one Chi was actually looking at. Hence "I see 1. in querySelector but not in UI." DevTools `textContent.slice(0,10)` on the visible list returned '[Discord] ' — no numPrefix — confirming the second path was running. This patch adds the same `var numPrefix = (i + 1) + '. ';` + `displayText = numPrefix + ...` to the second renderer. .map() now passes (entry, i) so i is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #681 only patched the primary
renderTasksat line 1148. The dashboard has a second task-list renderer at line 2280 (the dynamic-region contextual list) — that's the surface Chi was actually viewing. Hence "DevTools finds .task-text but text starts with '[Discord] '" — the 2nd renderer ran, no numPrefix.This PR adds the same numPrefix logic to the 2nd renderer.
.map()now passes(entry, i).Why I missed it first time
Greped for
task-numandtask-textand patched the first match. Should have searched the full bundle for ALLdisplayTextassignments before assuming one renderer.Test plan
🤖 Generated with Claude Code