Repository navigation
fix(toggle-tasks): log actionStr so taskIndex visible in voice-agent.log - #677
Merged
Merged
Conversation
Diagnostic gap: the log line printed bare action ('expand'/'collapse')
not the with-suffix actionStr ('expand:1'/'collapse:2'). After #674
added the taskIndex param, log entries like '[ToggleTasks] expand'
became ambiguous — couldn't tell if Gemini passed taskIndex or not.
Surfaced during 2026-05-13 23:59 PT debug session: per-task expand
appeared broken; couldn't determine from log whether the model omitted
taskIndex or the parsing failed.
1-line change. No UI change, no schema change.
liususan091219
pushed a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
…log (sonichi#677) Diagnostic gap: the log line printed bare action ('expand'/'collapse') not the with-suffix actionStr ('expand:1'/'collapse:2'). After sonichi#674 added the taskIndex param, log entries like '[ToggleTasks] expand' became ambiguous — couldn't tell if Gemini passed taskIndex or not. Surfaced during 2026-05-13 23:59 PT debug session: per-task expand appeared broken; couldn't determine from log whether the model omitted taskIndex or the parsing failed. 1-line change. No UI change, no schema change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1-line diagnostic fix.
console.logintoggleTasksTool(src/inline-tools.ts:573) now printsactionStr(e.g.expand:1) instead ofaction(e.g.expand). Makes voice-agent.log entries diagnostic after #674's taskIndex addition.Why
2026-05-13 23:59 PT: voice "expand the first task" appeared broken in UI. Couldn't tell from log whether Gemini omitted
taskIndexor my parsing failed. Both possibilities looked identical in[ToggleTasks] expand.Test plan
[ToggleTasks] expand:1. If it still reads[ToggleTasks] expand, Gemini didn't pass the param (model-side bug, not parsing).🤖 Generated with Claude Code