Repository navigation
fix(scroll): add amount param (small/medium/large → 150/400/800px) - #672
Merged
Merged
Conversation
Closes part of #671. The 600px step has been hardcoded since PR #88 when scroll was a phone-demo nudge. Today's call exposed the gap when caller asked to "scroll a little" past a window occluding the draft area — default 600 overshot in both directions. amount='small' (150px), 'medium' (400px, default), 'large' (800px). Tool description teaches the agent to pick small for "a little" / "a bit" phrasings. Task-expand all-or-nothing (the other half of #671) is left for a separate PR — needs a web-client change too.
This was referenced May 14, 2026
Merged
liususan091219
pushed a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
…onichi#672) Closes part of sonichi#671. The 600px step has been hardcoded since PR sonichi#88 when scroll was a phone-demo nudge. Today's call exposed the gap when caller asked to "scroll a little" past a window occluding the draft area — default 600 overshot in both directions. amount='small' (150px), 'medium' (400px, default), 'large' (800px). Tool description teaches the agent to pick small for "a little" / "a bit" phrasings. Task-expand all-or-nothing (the other half of sonichi#671) is left for a separate PR — needs a web-client change too.
2 of 3 tasks
sonichi
added a commit
that referenced
this pull request
Jun 2, 2026
…1396) The slide_control description claimed it "sends arrow keys to the frontmost browser window" — but the implementation has been DOM manipulation via Chrome execute javascript since #672's check-in (mutates `.slide.active` directly). The misleading description steered Sutando AWAY from slide_control when the deck's textarea was focused (live-edit demo on s5): assuming the keystroke trap would catch arrow keys here too, the agent fell back to press_key('leftarrow') — which IS arrow-key-based and got captured by the focused textarea (cursor moves left within the field, deck doesn't move). Hit during Observe-talk rehearsal 2026-06-01 23:32Z; transcript shows three failed press_key attempts to navigate back to s5 before user gave up. Update the description to: - Accurately describe the DOM-manipulation backend - Highlight focus-independence (works regardless of which element is focused) - Explicitly recommend over press_key('leftarrow'/'rightarrow'/'space') for slide nav, with the failure mode named Implementation unchanged. Description-only fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amountenum onscrollTool:small=150/medium=400(default) /large=800.Why
600px has been hardcoded since PR #88, when scroll was a phone-demo nudge. Today's owner call exposed the gap — caller asked to "scroll a little" past a window occluding the draft area, default 600 overshot in both directions across ~6 round-trips.
Scope
Only the Chrome JS-scroll branches (lines 64 + 77) consume the new
px. The AppleScript keyboard fallback at line ~85 still uses Page Down — that's viewport-page, a separate axis of imprecision; left for follow-up if needed.The task-expand all-or-nothing half of #671 is NOT in this PR — it needs a web-client change (per-task expand handler) too.
Test plan
npx tsc --noEmitclean🤖 Generated with Claude Code