Skip to content

test(gateway-bridge): pin the context-first prelude's --room fallback - #5984

Merged
sonichi merged 1 commit into
mainfrom
fix/bridge-test-prelude-room
Oct 28, 2026
Merged

sonichi merged 1 commit into
mainfrom
fix/bridge-test-prelude-room

Conversation

@qingyun-wu

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #5980, which merged before its CI finished. #5980 made the context-first prompt pass --room <room> to channel-env.sh; src/remote-gateway-bridge.test.py still pinned the old channel-env.sh ag2space) string, so python standalone tests (1/9) fails on main. This updates the two assertions to the new command. No production change.

Before / after evidence

On main (b72b5ca8), CI run 40753693504:

  FAIL the env prelude rides the sole gateway-calling step (context-first)
FAILED (1)
##[error]FAILED: tests/remote-gateway-bridge.test.py (exit 1)

At this head:

$ python3 src/remote-gateway-bridge.test.py | tail -1
PASS — all checks green

Test plan

  • python3 src/remote-gateway-bridge.test.py: pass.
  • No other test pins the old prelude string (git grep 'channel-env.sh ag2space)' finds only a manual script).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qingyun-wu
qingyun-wu requested a review from sonichi October 28, 2026 19:34
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Gate

✅ Diff coverage PASSES the 95% bar. Whole-tree (informational): 94%.

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • src/remote-gateway-bridge.test.py (100%)

Summary

  • Total: 1 line
  • Missing: 0 lines
  • Coverage: 100%

@sonichi sonichi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at c24acad (agent-assisted, Blue for Chi's seat).

  • The producer (src/result_markers.py, the context-first step) always emits channel-env.sh <dir> --room <quoted room> whenever there is a channel. No path emits the old ag2space) form, so the positive assertion pins the real string, and shlex quotes '!room:ag2.space' exactly as the test expects.
  • The negative check "channel-env.sh ag2space " not in skd still catches the failure it guards: a leaked default dir would render as ag2space --room ….
  • Locally at this head, python3 src/remote-gateway-bridge.test.py passes all checks. CI is green, including python standalone 1/9, which is red on main.

Test-only, so it is safe to merge to unbreak main.

@sonichi
sonichi merged commit 9826add into main Oct 28, 2026
37 checks passed
@sonichi
sonichi deleted the fix/bridge-test-prelude-room branch October 28, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants