Repository navigation
test(gateway-bridge): pin the context-first prelude's --room fallback - #5984
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Coverage Gate✅ Diff coverage PASSES the 95% bar. Whole-tree (informational): 94%. Diff CoverageDiff: origin/main...HEAD, staged and unstaged changes
Summary
|
sonichi
approved these changes
Oct 28, 2026
sonichi
left a comment
Owner
There was a problem hiding this comment.
Approve at c24acad (agent-assisted, Blue for Chi's seat).
- The producer (
src/result_markers.py, the context-first step) always emitschannel-env.sh <dir> --room <quoted room>whenever there is a channel. No path emits the oldag2space)form, so the positive assertion pins the real string, and shlex quotes'!room:ag2.space'exactly as the test expects. - The negative check
"channel-env.sh ag2space " not in skdstill catches the failure it guards: a leaked default dir would render asag2space --room …. - Locally at this head,
python3 src/remote-gateway-bridge.test.pypasses all checks. CI is green, including python standalone 1/9, which is red on main.
Test-only, so it is safe to merge to unbreak main.
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5980, which merged before its CI finished. #5980 made the context-first prompt pass
--room <room>tochannel-env.sh;src/remote-gateway-bridge.test.pystill pinned the oldchannel-env.sh ag2space)string, sopython standalone tests (1/9)fails on main. This updates the two assertions to the new command. No production change.Before / after evidence
On main (
b72b5ca8), CI run 40753693504:At this head:
Test plan
python3 src/remote-gateway-bridge.test.py: pass.git grep 'channel-env.sh ag2space)'finds only a manual script).🤖 Generated with Claude Code