Repository navigation
docs(windows): publish capability matrix with native verification - #5964
elCaptnCode wants to merge 2 commits into
Conversation
liususan091219
left a comment
There was a problem hiding this comment.
Code review found no blocking issue; not approving yet because there is no approval from another reviewer, the required Python CI shard is red, and the new Windows test has not run in CI.
What I checked at a28e6fc:
tests/windows-watcher-live.test.ps1runs the productionsrc/watch-tasks-stream.ps1in a disposable fixture with a cleared environment. Its dependencies (workspace_default.ps1,sutando_config.py) match what the watcher dot-sources (line 23). The PID-sentinel path it asserts matcheswatch-tasks-stream.ps1:30. Its cleanup refuses to delete anything outside the temp root.- Spot-checked matrix claims against main.
forHostPlatformexists insrc/inline-tools.ts. Thevoice-agent.ts:52warning does still listswitch_app. The quarantine-probe failure is the one #5963 fixes. - The doc keeps evidence types separate (native fixture, mocked contract, live) and says what was not exercised (macOS, packaged builds, real accounts).
- No hardcoded workspace paths in added lines. CLA is green.
Still missing / notes:
PowerShell + Windows runtimewas skipped on this PR (it is label-gated), so the new watcher test has only been run on the author's machine. Please add thewindows-cilabel once so it runs in CI.python standalone tests (4/9)failed inpool-restart-deliveries.test.py, which this PR does not touch. A maintainer needs to rerun it.docs/platform-support.mdstates that #5963 is unmerged and that the gateway is blocked. Those rows need updating when #5963, #5965 and thefcntlfix land.- Approval from a reviewer with Windows context.
— Sutando (susans-MacBook-Pro)
a28e6fc to
9762081
Compare
Coverage Gate✅ No Python changes — nothing to gate (bar: 95% on changed lines). |
9762081 to
d0b2f51
Compare
d0b2f51 to
b79afec
Compare
|
@cla-assistant check |
liususan091219
left a comment
There was a problem hiding this comment.
Reviewed at b79afec6. No blocking finding; not approving yet because the approval bar is not met.
Checked
- Docs + one new native test, no production change.
docs/platform-support.mdis linked from the README anddocs/catalog.json, and the body is careful to label mocked contracts and unverified surfaces as such rather than claiming them. tests/windows-watcher-live.test.ps1drives the realwatch-tasks-stream.ps1in a throwaway checkout with a cleared environment: initial, created and atomically renamed task files each emit once; a second write and a non-task file emit nothing; the PID sentinel names the launched process. Cleanup refuses to delete outside the temp root. It skips cleanly off Windows.- No added
~/.sutando/SUTANDO_WORKSPACEliteral. CI green at this head;license/clais success.
Missing for approval: no approval at this head. It needs one substantive approval from a reviewer with Windows context (the body asks @thinkall), and the hosted Windows workflow has not run (it needs a maintainer to make the PR eligible).
— Sutando (susans-MacBook-Pro)
liususan091219
left a comment
There was a problem hiding this comment.
Commenting at b79afec6. No blocking finding; not approving because the approval bar is not met. The head has not moved since my previous review.
Checked
- Docs plus one native test, no production change.
docs/platform-support.mdis linked from the README,docs/README.mdanddocs/built-in-tools.md, and registered indocs/catalog.json. - The matrix keeps native fixtures, mocked contracts and live round trips apart and records the failing
outbox-windowsresult instead of hiding it; it points at #5963 for the quarantine-probe fix. tests/windows-watcher-live.test.ps1runs the realwatch-tasks-stream.ps1against a disposable fixture with a cleared environment, checks initial/created/renamed tasks once, no duplicate or non-task event, and the PID sentinel; cleanup refuses paths outside the temp dir. It skips off Windows and is added to thewindows-runtimeworkflow, which only runs on schedule, dispatch or thewindows-cilabel.- CI: no failing check;
license/clasuccess (1 context); no unresolved threads; added-line hardcoded-path scan 0 hits.
Missing: one approval at this head (no APPROVED review at any head yet), preferably from a reviewer with Windows context. Not blocking: the new watcher test has not yet run on hosted Windows CI.
— Sutando (susans-MacBook-Pro)
Windows support claims currently mix implemented adapters with unverified user outcomes. Add a canonical Windows/macOS capability matrix with a dated source baseline, actual native Windows results, explicit limits, and a prioritized backlog. Link it from the README and documentation catalog.
Add a repeatable native
FileSystemWatchertest to the Windows runtime workflow. It runs the production watcher in a disposable checkout with a clean child environment: initial, created, and atomically renamed task files emit once; repeated writes and non-task files do not; its PID sentinel identifies the launched process.Related to #5499; this establishes the matrix and baseline, and intentionally leaves the broad tracker open. Desktop automation, real-account messaging/voice, packaged installations, and macOS behavior are explicitly unverified here. A failing Windows gateway import is recorded, not hidden by passing lock tests.
The first discovered import failure has a separate tested fix in #5963; the matrix also names the next
fcntlblocker rather than claiming full gateway recovery.The shared Windows sandbox fix and its native real-model canary are submitted separately in #5965, stacked on the shared-runner parent #5445. This matrix preserves the inspected main baseline until those fixes land.
Validation on Windows 11 build 26300, PowerShell 7.6.8, Python 3.13.7 and Node 24.19.0:
outbox-windows.test.pyran 18 methods: 17 passed; two subcases of the import method failed. The matrix names the exact quarantine libc-probe failure and preserves that evidence.All fixtures used isolated state. No live bot, desktop pixels, clipboard, external messages, or deployed restart was involved. The Windows workflow remains label/schedule/manual gated; Ubuntu CI alone is not presented as native Windows validation.
Reviewer focus: evidence boundaries and backlog priorities. @thinkall
CI follow-up (2026-10-29): main advanced again, with the unrelated product-label change in #5998. Refreshed the existing scoped patches unchanged from
d0b2f51e5onto maind68157f5e; current headb79afec65. Range-diff confirms every author patch is identical. CI run 40820250690 completed successfully at this exact head: all 21 main CI jobs passed. Review approval remains separate.At this exact head, the native Windows watcher and workspace encoding tests pass, along with the documentation audit (57 indexed documents / 60 Markdown files) and its five regression checks. The whitespace check passes. The full committed-diff scanner has clean applicable checks and reports PARTIAL because there are no in-scope Python files.
The separate Windows runtime workflow remains branch/label gated; native local evidence is distinct from hosted Windows CI. The requested
windows-cilabel was unavailable when checked, so hosted Windows eligibility remains a maintainer action. No live bot or deployed service was used.Current status (2026-10-30): latest CI run 40824328117 passed at unchanged head
b79afec65, and the raw commit status forlicense/clais success. The requested hosted Windows run is still skipped and needs maintainer-enabled eligibility. Required review, including approval from a reviewer with Windows context, remains outstanding. This PR is not merge-ready.