Skip to content

test: fix credential_pairs field name (main CI red since #5815) - #5852

Closed
sonichi wants to merge 1 commit into
mainfrom
fix/credential-pairs-test-name
Closed

sonichi wants to merge 1 commit into
mainfrom
fix/credential-pairs-test-name

Conversation

@sonichi

@sonichi sonichi commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Priority

Level: high
Reason: main CI has been red since the #5815 merge (3f38f18); this unblocks every open PR's python test shards.

Closes

N/A. CI repair. The same one-line change was first found and carried in #5851, which will rebase onto this PR.

Summary

tests/gateway-credential-sources.test.py reads EnvFiles.credential_values, a name no source defines; the field the owner module defines is credential_pairs. Guard.test_a_declared_bridge_reads_no_credential_file_and_the_host_resolves_what_it_carries errors in both subtests (package, src), and tests/hermetic-env-sentinels.test.py, which runs that suite, fails with it. This renames the one attribute access. No source change.

Checklist

Docs: N/A, test-only.

Before / after evidence

Before (origin/main 3f38f18):

ERROR: test_a_declared_bridge_reads_no_credential_file_and_the_host_resolves_what_it_carries (__main__.Guard...) [package]
AttributeError: 'EnvFiles' object has no attribute 'credential_values'. Did you mean: 'credential_pairs'?
ERROR: ... [src]
FAILED (errors=2)

After (this head):

python3 tests/gateway-credential-sources.test.py                     Ran 153 tests ... OK
python3 tests/hermetic-env-sentinels.test.py Sentinels.test_the_credential_owner_suite_reads_no_outer_selector   OK

Test plan

I ran both commands above under env -i HOME=$HOME PATH=$PATH nice -n 19. Edge cases, migrations and risks: N/A.

🤖 Generated with Claude Code

The declared-bridge guard test read EnvFiles.credential_values, a name no
source defines; the owner's field is credential_pairs. It errored in both
subtests on main and failed the sentinel suite that runs it.

Stand: Echo Act IV Pro
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Gate

✅ Diff coverage PASSES the 95% bar. Whole-tree (informational): 94%.

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@qingyun-wu qingyun-wu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 8914f9c: one-line test fix. EnvFiles on main defines credential_pairs (src/gateway_credential_sources.py:280, same in the vendored packages/ag2-sparrow copy, and register_pairs reads it at :488); the assertion named a field that never existed after #5815 landed. Approving; this unblocks main.

@sonichi sonichi closed this Oct 24, 2026
@sonichi sonichi reopened this Oct 24, 2026
@sonichi

sonichi commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

@cla-assistant check

@sonichi

sonichi commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

Covered by #5851 (merged as cf87f32), which carried the same one-line credential_pairs test fix. Closing because this PR's CLA status never posted.

@sonichi sonichi closed this Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants