Repository navigation
Conversation
The declared-bridge guard test read EnvFiles.credential_values, a name no source defines; the owner's field is credential_pairs. It errored in both subtests on main and failed the sentinel suite that runs it. Stand: Echo Act IV Pro Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
11 of 12 tasks
Contributor
Coverage Gate✅ Diff coverage PASSES the 95% bar. Whole-tree (informational): 94%. Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
qingyun-wu
approved these changes
Oct 24, 2026
qingyun-wu
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at 8914f9c: one-line test fix. EnvFiles on main defines credential_pairs (src/gateway_credential_sources.py:280, same in the vendored packages/ag2-sparrow copy, and register_pairs reads it at :488); the assertion named a field that never existed after #5815 landed. Approving; this unblocks main.
Owner
Author
|
@cla-assistant check |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority
Level: high
Reason:
mainCI has been red since the #5815 merge (3f38f18); this unblocks every open PR's python test shards.Closes
N/A. CI repair. The same one-line change was first found and carried in #5851, which will rebase onto this PR.
Summary
tests/gateway-credential-sources.test.pyreadsEnvFiles.credential_values, a name no source defines; the field the owner module defines iscredential_pairs.Guard.test_a_declared_bridge_reads_no_credential_file_and_the_host_resolves_what_it_carrieserrors in both subtests (package, src), andtests/hermetic-env-sentinels.test.py, which runs that suite, fails with it. This renames the one attribute access. No source change.Checklist
main(the main CI run at 3f38f18 failed; output below)Docs: N/A, test-only.
Before / after evidence
Before (
origin/main3f38f18):After (this head):
Test plan
I ran both commands above under
env -i HOME=$HOME PATH=$PATH nice -n 19. Edge cases, migrations and risks: N/A.🤖 Generated with Claude Code