Repository navigation
docs(review): a public witness quotes no private content; editing a leaked comment is not enough - #5386
Conversation
…l message text Stand: Echo Act IV Pro Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
qingyun-wu
left a comment
There was a problem hiding this comment.
Approve at 819d906. The 4 added lines in REVIEW.md lesson 15 are right, and they belong there, since REVIEW.md is the single source for review criteria.
- Naming agents by role and describing messages by kind is the right bar. The #5293 witness (issuecomment-6115174901) quoted the owner's request and the answering agent's reply verbatim, and redacting ids wouldn't have hidden either.
- "Deleted, not edited" is the correct remedy: GitHub keeps a comment's edit history visible to anyone who can read the PR.
- The text is docs-only and in English, and it reads cleanly within the lesson without changing its existing criterion.
Nit, optional: the lesson's Grounded by: line could cite the #5293 witness as the second incident, so the new sentence has its own grounding like the rest of REVIEW.md.
Coverage Gate✅ No Python changes — nothing to gate (bar: 95% on changed lines). |
…cite GitHub history Reconciles with CONTRIBUTING.md's transcript and task-file evidence: exact text is fine when written as publication-safe evidence or cleared for publication. Cites GitHub's edit-history docs, allows deleting sensitive revisions as well as delete-and-repost, and grounds the rule in the #5293 witness. Stand: Echo Act IV Pro Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Revised at e34124c after @keweichen's in-room review.
|
qingyun-wu
left a comment
There was a problem hiding this comment.
Approve at e34124c. Both of Kewei's points are handled well.
- Scope. "Private production content, from any participant" with a "publication-safe evidence, or cleared for publication" exception no longer conflicts with CONTRIBUTING.md. That file asks witnesses to quote task files (CONTRIBUTING.md:152, "Quote the task file, not just the log"), and test-run task files are written as evidence, so they stay quotable. Production owner/agent text doesn't. "Closely paraphrase" closes the obvious workaround.
- History. The linked GitHub doc does say edit history is visible to anyone with read access. Both remedies are correct: delete and repost, or delete each sensitive revision. Adding "check replies and reviews that quote or paraphrase it" covers the copy that usually survives.
- Grounding. #5293's first witness is now cited, so the rule is checkable like the rest of the file.
The prose is fine, and the diff touches REVIEW.md only. CI was still running when I checked (23 success, 7 in progress, 0 failing).
Stand: Echo Act IV Pro Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
qingyun-wu
left a comment
There was a problem hiding this comment.
Re-approve at cdc3f6e. The only change since my approval at e34124c is one grounding line in REVIEW.md, which now says what was redacted ("room, agent and task identities"); the rule text itself is unchanged. The title now matches the rule. CI was still running when I approved (14 success, 16 in progress, 0 failing).
Stand: Echo Act IV Pro Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@cla-assistant check |
john-the-dev
left a comment
There was a problem hiding this comment.
Approve at 76ede7140. Reviewed by Sutando (Rui's agent), posted as john-the-dev. Rui's Codex core passed this exact head.
What it changes. Docs only: one file, REVIEW.md, lesson 15, +11/-1.
Scope is right.
- The rule covers private production content from any participant, and nothing broader.
- Exact text stays allowed when it was written as publication-safe test evidence, or when it was cleared for publication.
- So CONTRIBUTING.md's before/after output, task-file fields, transcript excerpts and real round-trip requirements all still apply. Authors run the real service with safe test content.
The GitHub claim is accurate. Per GitHub's "Tracking changes in a comment" docs, anyone with read access can see a comment's edit history. An edit alone leaves the earlier text visible. Both remedies work: delete and repost, or delete every sensitive revision. The rule also correctly says to check replies and reviews that quote the comment.
Grounding. The #5293 witness is a fitting example: ids were redacted, but the owner's question and two agents' answers were quoted.
Checks.
tests/review-preflight.test.pypasses (44 tests) at this head.- Hardcoded-path and root-artifact checks are clean.
- CI is green.
liususan091219
left a comment
There was a problem hiding this comment.
Ready to approve.
Reviewed at 76ede71. Docs only: REVIEW.md lesson 15, +11/-1 (git diff --stat origin/main...pr).
Verified:
- REVIEW.md:280-287 adds the publication rule: private production content from any participant, functional labels, an exception for publication-safe or cleared text, and edit-then-delete remediation. REVIEW.md:293-295 adds #5293 to the lesson's grounding. Lesson numbering is unchanged: 15 at :266, 16 at :297.
- python3 tests/review-preflight.test.py under env -i at this head: "Ran 44 tests ... OK". REVIEW.md still parses for review-preflight.py.
- bash scripts/review-checks.sh --diff on the PR diff: exit 0. Hardcoded paths and root artifacts are clean, and prose-cap had no in-scope files. A manual grep of the added lines for .sutando, SUTANDO_WORKSPACE, /Users/ and /home/ found nothing.
- Gates: CI all pass (PowerShell skipped). The commit status endpoint lists license/cla=success (1 context, so it is present, not absent). There are no review threads.
- Approvals at this head: qingyun-wu (review 5485859190, which follows substantive approvals 5485753311 and 5485794250) and john-the-dev (5485900409). reviewDecision is APPROVED.
- This is a docs-only reviewer-checklist change, so there is no live path and no round trip is owed.
Nit (not blocking): CONTRIBUTING.md:158 asks voice PRs for a transcript excerpt from data/conversation.sqlite. Under the new rule, that excerpt has to come from a test session written as evidence, not from a real owner conversation. A one-line cross-reference there would stop the two documents from pulling in different directions.
— Sutando (susans-MacBook-Pro)
What
REVIEW.md lesson 15 (the live-path witness gate) gains a publication rule, +11/-1:
Why
The first live-witness comments on #5293 redacted room, agent and task IDs. They still quoted the owner's real question and two agents' real answers, which revealed what the owner asked and which personal accounts their agents handle. The owner had them deleted and reposted with functional labels. Whether text exposes owner context is a judgement, not a pattern, so this goes in the reviewer checklist and not in
review-checks.sh.Evidence
git diff origin/main --stat:REVIEW.md | 12 +++++++++++-, docs only.python3 tests/review-preflight.test.py(parses REVIEW.md forreview-preflight.py):OK, 44 tests.review-checks: hardcoded paths and root artifacts clean. Prose-cap had no in-scope files.🤖 Generated with Claude Code