Skip to content

Fix discord bridge bugs from Codex review - #52

Merged
sonichi merged 1 commit into
mainfrom
fix-discord-bridge-bugs
Mar 30, 2026
Merged

sonichi merged 1 commit into
mainfrom
fix-discord-bridge-bugs

Conversation

@sonichi

@sonichi sonichi commented Mar 30, 2026

Copy link
Copy Markdown
Owner

Fixes 3 bugs found by Codex in PR #50: pairing NameError, incomplete snapshot handling, watcher false triggers.

🤖 Generated with Claude Code

1. Pairing: load access.json before writing pending entry (was
   NameError on first unpaired DM)
2. Forwarded messages: extract embeds and attachments from snapshots,
   not just content text
3. Watcher: internal loop on false triggers, pgrep -x fswatch for
   accurate dedup

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sonichi
sonichi merged commit 7217b66 into main Mar 30, 2026
@sonichi
sonichi deleted the fix-discord-bridge-bugs branch March 30, 2026 17:32
liususan091219 pushed a commit to liususan091219/sutando-fork that referenced this pull request May 28, 2026
…onichi#52)

1. Pairing: load access.json before writing pending entry (was
   NameError on first unpaired DM)
2. Forwarded messages: extract embeds and attachments from snapshots,
   not just content text
3. Watcher: internal loop on false triggers, pgrep -x fswatch for
   accurate dedup

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
liususan091219 added a commit that referenced this pull request Jun 21, 2026
…zation (#1736)

- #54 src/meeting-tools.ts, #53 src/browser-tools.ts (js/polynomial-redos):
  the query-strip `/\?.*$/` backtracks polynomially on input with many '?'.
  Replace with split-on-'?' / indexOf — linear, same behavior (browser-tools
  keeps the '?…' redaction marker).
- #52 skills/obsidian-vault/tools.ts (js/incomplete-sanitization): the
  frontmatter title escaped '"' but not backslash. Now escapes '\' first,
  then '"', and wraps the value in a double-quoted YAML scalar so titles with
  '\', '"', or ':' can't break/inject the frontmatter.

tsc --noEmit clean.


Claude-Session: https://claude.ai/code/session_01DZ2R8EDYw6v743samaxbQS

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant