Repository navigation
startup.sh: honor NGROK_DOMAIN for stable tunnel URL - #213
Merged
Merged
Conversation
health-check.py's auto-restart path (PR #207) already reads NGROK_DOMAIN and passes --domain=... so the tunnel comes back on the same URL. But startup.sh still ran plain 'ngrok http 3100', so the initial tunnel URL was random and the Twilio webhook had to be updated manually on every first boot. Mirror the health-check logic in startup.sh: read NGROK_DOMAIN from .env, pass --domain=... if set, otherwise fall back to the old random-URL behaviour. Document the variable in .env.example. Motivated by the Mac Mini migration — ngrok reserved domain was set in .env but startup.sh ignored it, so the first boot after reboot still printed "⚠ Update Twilio webhook to: ...". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
liususan091219
pushed a commit
to liususan091219/sutando-fork
that referenced
this pull request
May 28, 2026
health-check.py's auto-restart path (PR sonichi#207) already reads NGROK_DOMAIN and passes --domain=... so the tunnel comes back on the same URL. But startup.sh still ran plain 'ngrok http 3100', so the initial tunnel URL was random and the Twilio webhook had to be updated manually on every first boot. Mirror the health-check logic in startup.sh: read NGROK_DOMAIN from .env, pass --domain=... if set, otherwise fall back to the old random-URL behaviour. Document the variable in .env.example. Motivated by the Mac Mini migration — ngrok reserved domain was set in .env but startup.sh ignored it, so the first boot after reboot still printed "⚠ Update Twilio webhook to: ...". Co-authored-by: Chi <wangchi@Chis-Mac-mini.local> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
health-check.py's auto-restart path (#207) already reads
NGROK_DOMAINand passes--domain=...so the tunnel comes back on the same URL. Butstartup.shstill ran plainngrok http 3100, so the initial tunnel URL was random and the Twilio webhook had to be updated manually on every first boot.Mirror the health-check logic in
startup.sh: readNGROK_DOMAINfrom.env, pass--domain=...if set, otherwise fall back to the old random-URL behaviour. Document the variable in.env.example.Motivated by the Mac Mini migration — ngrok reserved domain was set in
.envbutstartup.shignored it, so the first boot after reboot still printed '⚠ Update Twilio webhook to: ...'.Test plan
bash -n src/startup.sh— syntax ok🤖 Generated with Claude Code