Skip to content

feat(pr-template): add Priority section for triage visibility - #2027

Merged
qingyun-wu merged 2 commits into
sonichi:mainfrom
john-the-dev:feat/pr-priority-labels
Jul 9, 2026
Merged

qingyun-wu merged 2 commits into
sonichi:mainfrom
john-the-dev:feat/pr-priority-labels

Conversation

@john-the-dev

Copy link
Copy Markdown
Collaborator

Priority

Level: low
Reason: quality-of-life improvement for PR triage, no deadline

Closes

N/A — new feature.

Summary

Adds a Priority section (high / medium / low + one-line reason) to .github/PULL_REQUEST_TEMPLATE.md. PR authors fill it in when opening; reviewers see urgency and justification at a glance without hunting for it.

Pairs with three GitHub labels that should be created in the repo (requires maintainer write access):

gh label create "priority: high"   --color "D93F0B" --description "Blocks a release, security fix, or another PR's merge"
gh label create "priority: medium" --color "E4A800" --description "Meaningful improvement, should land this week"
gh label create "priority: low"    --color "0075CA" --description "Nice-to-have, no deadline pressure"

Checklist

  • Confirmed no other open PR adds priority labeling
  • Git author email matches CLA-signed email
  • Single concern per PR
  • Feature isn't already covered
  • N/A for tests (template-only change)
  • Doesn't touch V1-workspace-hold areas

Test plan

Open a new draft PR and verify the Priority section appears in the template editor with the fill-in fields pre-populated.

@github-actions

github-actions Bot commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Gate

✅ No Python changes — nothing to gate (bar: 95% on changed lines).

@john-the-dev
john-the-dev marked this pull request as ready for review July 8, 2026 17:26
@qingyun-wu

Copy link
Copy Markdown
Collaborator

Automated review:

  1. skills/report-feedback/report-feedback.py:84-89 hard-codes the packaged-app workspace as ~/.sutando/repo/workspace. That breaks the “different checkout” fallback whenever the packaged app is using a config-driven workspace override, because the cloud token will live under that overridden workspace instead. The current checkout path is resolved via resolve_workspace(), but the alternate packaged-app probe ignores the same workspace contract, so signed-in users can still get NOT_SIGNED_IN from this skill.

  2. skills/report-feedback/report-feedback.py:123-132 sorts log files newest-first, then truncates the concatenated excerpt with [-8000:]. When the combined excerpt exceeds 8 KB, that drops the beginning of the string first, which is exactly where the newest log tails were appended. In practice the attachment can end up containing mostly older logs while omitting the freshest failure context the report was supposed to capture.

@qingyun-wu

Copy link
Copy Markdown
Collaborator

Automated review:

This PR is currently mixing two unrelated concerns. .github/PULL_REQUEST_TEMPLATE.md adds the Priority section, but skills/report-feedback/SKILL.md and skills/report-feedback/report-feedback.py add a full new skill that is already proposed in open PR #2010.

That makes this PR both duplicate-scope and multi-concern, which blocks review under the repo's CONTRIBUTING guidance. Please split the skill back out or keep it on #2010 so this PR only contains the template change.

@qingyun-wu

Copy link
Copy Markdown
Collaborator

Automated review:

This branch is not isolated to the PR-template change in .github/PULL_REQUEST_TEMPLATE.md:7-15. Its merge diff also adds the unrelated report-feedback feature in skills/report-feedback/SKILL.md:1 and skills/report-feedback/report-feedback.py:1.

That means merging #2027 would ship extra product code from another PR, which conflicts with the single-concern rule in CONTRIBUTING.md and makes the review target inaccurate. Please rebase/cherry-pick the template commit onto main (or split out the extra files) before this is reviewed further.

@qingyun-wu

Copy link
Copy Markdown
Collaborator

Automated review:

This branch is not single-concern right now. In addition to the PR-template change in .github/PULL_REQUEST_TEMPLATE.md:7-15, it also carries the full report-feedback feature (skills/report-feedback/SKILL.md:1 and skills/report-feedback/report-feedback.py:1). git log origin/main..HEAD shows the whole feat(skills): report-feedback skill stack under this PR. If #2010 lands first, this PR will duplicate/conflict with it; if it lands first, the title/body no longer describe the shipped change. Please rebase or split this PR down to the template-only diff.

Adds a Priority section (high / medium / low) with a reason field to
the PR template so reviewers can see urgency and its justification at
a glance. Pairs with the three GitHub labels added in this commit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EL2XBcV3RsWhevzTPtW4jw
@john-the-dev
john-the-dev force-pushed the feat/pr-priority-labels branch from f9ed495 to e32752d Compare July 8, 2026 18:48
@john-the-dev

Copy link
Copy Markdown
Collaborator Author

Addressed the review feedback. This branch was carrying the full report-feedback skill (which belongs to #2010) on top of the template change, making it multi-concern.

I've rebased the branch down to a single template-only commit — it now contains just the ## Priority section added to .github/PULL_REQUEST_TEMPLATE.md and nothing else:

$ git diff --stat origin/main...HEAD
 .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++++
 1 file changed, 10 insertions(+)

The report-feedback skill (and the two code issues raised in the first automated review — the hard-coded ~/.sutando/repo/workspace probe path and the [-8000:] newest-log truncation) stay scoped to #2010, where they'll be reviewed. This PR is now single-concern per CONTRIBUTING.

@qingyun-wu qingyun-wu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — LGTM. Lightweight, self-documenting, and the label taxonomy matches how triage actually happens. CI green.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@cla-assistant check

@qingyun-wu
qingyun-wu merged commit 2920877 into sonichi:main Jul 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants