[john-the-dev]

Summary

• /voice/toggle had a read-modify-write on voice_desired_state: read current value, compute toggle, assign back — all unprotected.
• With ThreadingHTTPServer (PR fix(agent-api): ThreadingHTTPServer + handler timeout so one stalled client can't wedge the API #1921), two simultaneous POSTs can interleave and double-toggle, landing the UI on the wrong state.
• Fix: add _voice_state_lock = threading.Lock() (module-level, near the voice_desired_state declaration) and acquire it around the toggle's read-then-assign.
• Harmless with the current single-threaded HTTPServer; necessary when fix(agent-api): ThreadingHTTPServer + handler timeout so one stalled client can't wedge the API #1921 lands.
• /voice/set plain assignment stays unlocked — single assignment is atomic under the GIL and has no read-modify cycle.

Test plan

• python3 tests/agent-api-delegation.test.py — PASS (no regression in the endpoint test suite)
• python3 tests/agent-api-task-field-injection.test.py — PASS

🤖 Generated with Claude Code

https://claude.ai/code/session_01QB3qZQrwponfum2JFNvHeh

[john-the-dev]

Duplicate of #1928 which already fixes #1922 (voice_desired_state toggle lock). Closing.

[github-actions]

Coverage Gate

❌ Diff coverage BELOW the 95% bar — uncovered changed lines listed below. Whole-tree (informational): 33%.

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

• src/agent-api.py (50.0%): Missing lines 768-769

Summary

• Total: 4 lines
• Missing: 2 lines
• Coverage: 50%

src/agent-api.py

Lines 764-773

  764 
  765         if path == "/voice/toggle":
  766             if not self.check_auth():
  767                 return
! 768             with _voice_state_lock:
! 769                 voice_desired_state = "connected" if voice_desired_state == "disconnected" else "disconnected"
  770             self.send_json(200, {"state": voice_desired_state})
  771             return
  772 
  773         if path == "/voice/set":

---