Repository navigation
fix(scripts): drop hardcoded personal usernames from probe + catchup (public code) - #1725
Merged
Merged
Conversation
…dotenv_read probe The dotenv_read sandbox-refusal probe hardcoded `/Users/wangchi/Desktop/sutando/.env` as the secret-file path it asks the sandboxed agent to read. That leaks a personal username into public OSS code. The probe only needs *a* secret-looking path to verify the agent refuses — swap to the generic `~/.sutando/.env` (zero behavior change; the refusal regex is unaffected). Caught in a repo-wide cold-review (Pro). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… comment The comment documenting the pre-#1056 hardcoded-path removal still embedded a personal username (/Users/xueqingliu/...). Genericize to /Users/<name>/ — keep the #1056 review attribution. Last hardcoded personal username in public code. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sonichi
changed the title
sonichi
commented
Jun 20, 2026
sonichi
left a comment
sonichi
left a comment
Owner
Author
There was a problem hiding this comment.
Cold review (Echo Act IV) — LGTM, clean, no blockers.
probe-team-sandbox.sh:/Users/wangchi/Desktop/sutando/.env→~/.sutando/.env. Probe semantics preserved (still tests that the sandbox refuses to read a .env); no username.catchup-after-startup.sh:18: comment/Users/xueqingliu/...→/Users/<name>/..., and dropped theqingyun-wuname from the attribution line. Comment-only, zero behavior change.
Both generic, no functional change. Confirmed via repo-wide grep that #1723 + #1725 together leave zero /Users/<realname> on main. Approve pending owner merge.
Contributor
|
@cla-assistant check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hardcoded personal usernames in public OSS code (the last
/Users/<realname>refs outsideskills/submit-use-case/, which #1723 handles):scripts/probe-team-sandbox.sh:42— thedotenv_readsandbox-refusal probe hardcoded/Users/wangchi/Desktop/sutando/.env. The probe only needs a secret-looking path to verify refusal → generic~/.sutando/.env. Zero behavior change.skills/catchup-after-startup/scripts/catchup-after-startup.sh:18— a comment documenting a past fix still embedded a collaborator's username (/Users/xueqingliu/...) → genericized to/Users/<name>/(kept the feat(catchup-after-startup): rebuild last-session context on fresh start #1056 review attribution).Caught in repo-wide cold-review (Pro flagged #1, Pro+Air independently flagged #2). With #1723 (submit-use-case) + this PR, zero
/Users/<realname>references remain on main (tests/use/Users/test/placeholders, fine).bash -nclean on both.🤖 Generated with Claude Code