[qingyun-wu]

Milestone status (workspace-revamp M0–M3)

Milestone	Status
M0-1 (workspace structure)	✅ shipped (PR #1395)
M1-1 (migrate legacy workspace)	✅ shipped (sutando-migrate skill)
M0-2 (.claude_sutando/ in-repo)	✅ shipped
M1-2 (migrate .claude/ → .claude-sutando/)	✅ shipped
M2 (sync engine)	🟡 in-flight (this PR is part of M2)
M3 (docs sweep + dogfooding + E2E)	⏸ not yet started

---

PR-2 followup to #1445. Owner directive 2026-06-04: vault URL resolution should mirror how workspace path is resolved (config-file canonical), not env-var canonical. Includes deprecation banner on the legacy script (Option C: parallel deprecation, no behavior change for existing users).

Summary

• Vault URL resolver: priority chain is now --vault-url <url> → sutando.config.local.json (vault.remote_url) → sutando.config.json (tracked default) → .env SUTANDO_MEMORY_REPO (deprecated; warn-and-honor for one release)
• SUTANDO_VAULT env var (introduced in feat(sync-workspace): workspace-as-git-repo + memory translation layer (PR-1) #1445) removed — brand new, no users to deprecate; CLI flag + config-file is the canonical surface
• --vault-url <url> CLI flag added (two forms: --vault-url X and --vault-url=X)
• sync-memory.sh keeps working with a one-line deprecation banner + migration recipe in the header (silence with SUTANDO_SYNC_MEMORY_SUPPRESS_DEPRECATION=1)
• Reference sweep (user-facing): crons.example.json + docs/memory-sync.md
• 48/48 tests pass (was 39 in feat(sync-workspace): workspace-as-git-repo + memory translation layer (PR-1) #1445 v6); +9 new tests cover the new resolver chain, flag forms, env-var removal, priority, and deprecation banner

Why Option C (parallel deprecation, not exec-shim)

The two scripts implement different storage architectures:

• sync-memory.sh: rsync to a separate ~/.sutando/memory-sync/ clone
• sync-workspace.sh: workspace IS the git repo, branch-per-host topology

A exec sync-workspace.sh "$@" shim would silently auto-init users' workspaces on first cron fire — destructive. Option C keeps both functional through the transition; PR-2.1 removes sync-memory.sh after dogfooding.

Test plan

• bash tests/sync-workspace.test.sh — expect Total: 48 — pass: 48, fail: 0
• Smoke test --vault-url flag: bash scripts/sync-workspace.sh --vault-url <url> --status resolves cleanly
• Smoke test config-file: write vault.remote_url into sutando.config.local.json, run --status, see URL in output
• Smoke test legacy .env: only SUTANDO_MEMORY_REPO=... → see deprecation banner + URL resolves
• Smoke test sync-memory.sh: invoke → see deprecation banner; set SUTANDO_SYNC_MEMORY_SUPPRESS_DEPRECATION=1 → no banner

Not in scope (PR-2.1 / later)

• Removing sync-memory.sh entirely (waits for dogfooding observation)
• Doc sweep of workspace-design.md / workspace-contract.md (architectural docs, out-of-scope for user-facing PR-2)
• Internal-caller refs in health-check.py / core_heartbeat.py (those still use rsync flow; shim covers them during transition)

🤖 Generated with Claude Code

[github-actions]

@cla-assistant check

[liususan091219]

Verdict: LGTM — clean, consistent, and it folds in the #1445 review feedback. COMMENT (not changing your formal state).

This is exactly the right shape for PR-2: the vault URL now resolves through the same config-canonical chain the workspace path uses, so there's one mental model for "where does Sutando get its locations." Nice.

Things I like:

1. The 4-tier resolver mirrors the workspace-path contract (--vault-url → sutando.config.local.json → sutando.config.json → .env SUTANDO_MEMORY_REPO). Config-canonical, env-deprecated — consistent with resolve_workspace, so nobody has to learn a second resolution order.
2. SUTANDO_VAULT removed cleanly. It was introduced one PR ago (#1445) with zero users, so deleting it now (rather than carrying a deprecation cycle for a never-shipped var) keeps the surface honest. Good call to not accrete legacy.
3. The set-e trap elimination — relying on the already-set -a; . .env-loaded SUTANDO_MEMORY_REPO env var instead of a fresh var=$(grep … | head | cut …) is the right fix for Mini's #1445 v4 Medium: it removes the whole "grep-returns-nonzero-under-set-e" + path-shaped-capture failure class, not just one instance.
4. Both flag forms (--vault-url X via _consume_next and --vault-url=X via prefix) — covers the two ways people actually type it.
5. Deprecation is Option-C parallel — sync-memory.sh keeps working with a one-line, suppressible banner + an inline migration recipe. No behavior change for existing users; they're nudged, not broken.

Non-blocking observations:

• Priority 2/3 delegates to scripts/sutando-config.sh vault-url with 2>/dev/null || true — good that a missing/!malformed config degrades to the next tier rather than aborting. Worth a one-line test asserting "no config + no flag + no env → empty VAULT_URL → clean error", if not already in the 48.
• The legacy .env warn-and-honor message fires every invocation while SUTANDO_MEMORY_REPO is set — fine for one release, but consider gating it behind the same _SUPPRESS_DEPRECATION knob so a user mid-migration isn't spammed twice (sync-memory banner + this one).
• crons.example.json prompt now points at sync-workspace.sh — good catch updating the user-facing reference in the same PR rather than leaving it dangling.

Cross-PR linkage: sits cleanly between #1445 (PR-1: workspace-as-git-repo + the carrier .gitignore) and #1447 (PR-3: config-driven carrier). My one carry-over concern from the #1445 review — the !notes/** wholesale carrier tracking sensitive personal content — isn't touched here (it's PR-1/PR-3 territory); flagging only so it isn't lost in the stack.

Tests: 48/48 (was 39) with +9 for the resolver chain + flag forms — good coverage of the new surface.

Ready to merge from my read once the stack lands in order. Workspace-contract area, so final go/no-go is the owners'.

— Lucy (Mac Studio bot)