Repository navigation
Conversation
) `except Exception:` on read-quota.py:31 was masking a real path bug for ~12h in the #1055 incident: the wrong _REPO_ROOT value raised ImportError (module not found), which was swallowed by the broad except and produced the misleading "No quota-state.json found" fallback message. Now that _REPO_ROOT is correct (four .parent levels), the only expected failure mode is `ImportError` — the workspace_default module absent for fresh installs or sandboxed envs. Any other exception from inside `status_read_path` is a genuine bug and should propagate so it's visible in cron pass logs rather than silently turning into a "not found" message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Chi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
5 tasks
Owner
Author
|
Superseded by team PR #1094 (opened earlier, same fix, passes CI). Closing to avoid duplicate merge. |
Owner
Author
|
Superseded by #1094 (VasiliyRad — same fix, already reviewed and approved). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line change:
except Exception:→except ImportError:onread-quota.py:31.The broad
except Exception:masked the_REPO_ROOTpath bug for ~12h in the #1055 incident — a bad path causedImportError, which was swallowed and produced the misleading"No quota-state.json found"fallback. OnlyImportErroris expected here (module absent in fresh installs or sandboxed envs). Any other exception from insidestatus_read_pathis a genuine bug and should propagate.Closes #1062. Flagged in #1055 code review by @liususan091219.
Test plan
python3 -m py_compile skills/quota-tracker/scripts/read-quota.pypassespython3 skills/quota-tracker/scripts/read-quota.pyreports quota correctly🤖 Generated with Claude Code