Repository navigation
Conversation
Per Lucy's #1055 review: the bare `except Exception:` on line 26 masked the path off-by-one for half a day. An `ImportError` is the only expected failure here — `workspace_default` not importable (wrong sys.path). Narrowing to `ImportError` lets unexpected exceptions (AttributeError, TypeError, disk failure) surface to the caller instead of silently setting `_canonical = None` and printing a misleading 'not found' message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…propagate The broad `except Exception` swallowed runtime errors from workspace_default (e.g. a future refactor raising an unexpected exception type), silently setting `_canonical = None` and producing the misleading "No quota-state.json found" message instead of the real cause. Narrows the guard to `except ImportError` — the only expected failure mode (workspace_default not on sys.path). Any other exception now propagates and surfaces in cron pass logs. Closes #1062 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Chi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Owner
Author
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exceptioninread-quota.pysilently swallowed any runtime error fromworkspace_default, producing a misleading "No quota-state.json found" messageexcept ImportError— the only expected failure (module not on sys.path); all other exceptions now propagate to cron logs_canonical = None, non-ImportError propagates, and source no longer containsexcept Exception:Closes #1062
Test plan
python3 tests/quota-tracker-import-guard.test.py→ 3 tests pass🤖 Generated with Claude Code