Repository navigation
Conversation
Per Lucy's #1055 review: the bare `except Exception:` on line 26 masked the path off-by-one for half a day. An `ImportError` is the only expected failure here — `workspace_default` not importable (wrong sys.path). Narrowing to `ImportError` lets unexpected exceptions (AttributeError, TypeError, disk failure) surface to the caller instead of silently setting `_canonical = None` and printing a misleading 'not found' message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per Lucy's #1055 review (item 1): the bare
except Exception:onread-quota.py:26masked a path off-by-one for half a day — any unexpected error set_canonical = Noneand printed the misleading "not found" message instead of surfacing the real failure.The only anticipated failure at this call site is
ImportError(workspace_default not importable because sys.path is wrong). Narrowing toImportError:AttributeError,TypeError, disk errors, and any other unexpected exceptions propagate to the callerChange
One line changed. No behavior change for the normal path or for missing-module installs.
Test plan
python3 skills/quota-tracker/scripts/read-quota.pyon a machine withworkspace_defaultimportable → same output as before🤖 Generated with Claude Code