Repository navigation
tests(discord-bridge, telegram-bridge): task-file fields + allowlist coverage - #1239
Closed
bassilkhilo-ag2 wants to merge 1 commit into
Closed
bassilkhilo-ag2 wants to merge 1 commit into
bassilkhilo-ag2 wants to merge 1 commit into
Conversation
…tests Adds two targeted test files extracted from PR sonichi#1226 after stripping the conflicting slack-bridge-tofu and py39-compat files (which overlap with open PRs sonichi#1190 and sonichi#1188/sonichi#1199 respectively). - tests/discord-bridge-task-file-fields.test.py (5 guards): verifies PR sonichi#1077 port — task file includes channel_name, guild_name, source_message_id, DM fallback ("DM"), and newline sanitization. - tests/telegram-bridge-allowlist.test.py (13 tests): first coverage for telegram-bridge.py access control — load_allowed() behavior under each access.json state, and tofu_onboard() writes on first install. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
VasiliyRad
approved these changes
May 27, 2026
VasiliyRad
left a comment
VasiliyRad
left a comment
Contributor
There was a problem hiding this comment.
Clean — these are the two novel test files I called out in my RC of #1226 ('discord-bridge-task-file-fields' + 'telegram-bridge-allowlist'). Properly extracted from the bundle this time. 2 files, no source changes, no bundling. LGTM 👍
Collaborator
Author
|
Closing per owner instruction — autonomous PR creation halted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #1226 — stripped to only the two novel test files (dropped
slack-bridge-tofu.test.pywhich conflicts with open PR #1190, andpy39-compat-remaining.test.pywhich overlaps with #1188/#1199).Files
tests/discord-bridge-task-file-fields.test.py— 5 structural guards for the PR #1077 port that addedchannel_name,guild_name,source_message_idto discord task files:channel_namefield present intask_file.write_textblockguild_namefield presentsource_message_idfield present"DM") used when channel has no.name/ guild isNonetests/telegram-bridge-allowlist.test.py— 13 behavioral tests, first coverage fortelegram-bridge.pyaccess control:load_allowed()returnsNone(TOFU-eligible),set()(locked),{id}(restricted) under eachaccess.jsonstatetofu_onboard()writes the file on first install, is idempotent on re-runBoth tests pass locally.
🤖 Generated with Claude Code