Repository navigation
test(join-trigger, inline-tools): 28 tests — mention-prefix format + workspace skill scan - #1213
Closed
bassilkhilo-ag2 wants to merge 1 commit into
Closed
bassilkhilo-ag2 wants to merge 1 commit into
bassilkhilo-ag2 wants to merge 1 commit into
Conversation
…workspace skill scan join-trigger-mention-prefix.test.py (25): Guards the @-mention prefix that join-trigger adds to voice-session invitations — correct format, trailing whitespace, newline handling, multi-phrase edge cases. Closes sonichi#1113 test coverage gap. inline-tools-workspace-skills-scan.test.ts (3): Structural tests verifying inline-tools scans $SUTANDO_WORKSPACE/skills/ (not just repo-root skills/) for dynamically-loaded skill manifests. Guards the workspace-skills path from sonichi#1081. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
VasiliyRad
approved these changes
May 26, 2026
VasiliyRad
left a comment
VasiliyRad
left a comment
Contributor
There was a problem hiding this comment.
28 tests covering mention-prefix format + workspace skill scan. 2 test files, no source changes. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 28 tests for two distinct coverage gaps.
tests/join-trigger-mention-prefix.test.py(25 tests) — #1113 companionGuards the
@-mention prefix format thatJoinTriggerprepends to voice-session invitations:<@USER_ID>with exactly one trailing spaceNonetests/inline-tools-workspace-skills-scan.test.ts(3 tests) — #1081 companionStructural tests ensuring
inline-toolsscans$SUTANDO_WORKSPACE/skills/for dynamically-loaded skill manifests (not just the repo-rootskills/directory):All 28/28 tests pass.