[liususan091219]

Closes #1052. Stacks on top of #1051 — the diff currently includes #1051's commits; once that merges this PR rebases to the clean redundancy-cleanup-only diff.

Why

Per the table in #1052, three storage paths encode the same atoms:

atom	source 1 (canonical post-#1051)	source 2	source 3
user / agent utterance	voice / phone / discord_voice row (per-utt)	session_events event_name='user:<text>' / 'sutando:<text>'	sessions.events JSON
tool call	surface row kind='tool_call' (realtime, #1051)	session_events event_name='tool_call:<name>' / 'tool_result:...'	sessions.tool_calls JSON

Row-count proof on the live workspace db pre-this-PR: voice 3673 rows but session_events 20027 rows (the pre-#1051 v_voice query reading 'user:'/'sutando:'/'tool_call:' prefixes returned ~10574 rows — 3× the surface table for the same data). Cost: more disk, more confused readers (you can SELECT from any of 3 places and get the same number).

What

Single source of truth per atom:

• Utterances: surface tables voice / phone / discord_voice only.
• Tool calls: surface tables only (kind='tool_call', written real-time via recordToolCall from refactor(conversation-store): per-surface tables + realtime tool_call writes #1051).
• Lifecycle events (session_started, session_ended, error, task_delegated, etc.): session_events only.
• sessions keeps just the per-session rollup metadata (duration, transcript_lines, tool_count, etc.) — no more JSON columns.

Schema change

ALTER TABLE sessions DROP COLUMN tool_calls;
ALTER TABLE sessions DROP COLUMN events;

Guarded via PRAGMA table_info so re-init is a no-op. SQLite 3.35+ required (node:sqlite ships with newer than that).

Writer-side changes

file	line(s)	dropped
src/conversation-store.ts	recordSession	tool_calls + events cols in INSERT; session_events fan-out filter for user:/caller:/sutando:/assistant:/tool_call:/tool_result: prefixes
src/voice-agent.ts	onToolCall, onToolResult, turn-handler	tool_call:, tool_result:, ${evtRole}:${content} pushes
skills/phone-conversation/scripts/conversation-server.ts	onToolCall, onToolResult, turn-handler	tool_call:, tool_result:, caller:, sutando: pushes
skills/discord-voice/scripts/discord-voice-server.ts	onToolCall, onToolResult, turn-handler	tool_call:, tool_result:, user:, sutando: pushes

Lifecycle pushes (session_started, session_ended, error:, task_delegated:, task_result:, channel_result:, rec_indicator:, call_ended) preserved across all 3 surfaces.

Reader-side changes

• skills/regression-search/scripts/diagnose-call.py:_build_transcript already updated in refactor(conversation-store): per-surface tables + realtime tool_call writes #1051 to read surface tables (UNION ALL + kind != 'tool_call' filter).
• skills/regression-search/scripts/diagnose-call.py:find_metrics updated here:
  • tool_calls list rebuilt from surface tables (UNION ALL + kind = 'tool_call' WHERE session_id = ?)
  • events list pulled directly from session_events WHERE session_id = ? OR call_sid = ?
  • Output shape ({name, durationMs, timestamp} per tool call; {event, timestamp} per event) unchanged.

SessionMetrics interface keeps toolCalls + events fields for backwards compat with existing callers — silently ignored / filtered now instead of persisted.

Verification

• ✅ tsc --noEmit clean
• ✅ Migration applied to live workspace db: sessions 13 → 11 columns; existing rows preserved with metadata intact
• ✅ All 3 surface servers (voice / phone / discord-voice) restart cleanly on the new code
• ✅ diagnose-call.py syntax check + structural rewrite

Risks

• External callers reading sessions.tool_calls or sessions.events JSON outside this repo will break post-merge. Mitigation: anyone affected can rebuild the same data via the surface tables (for tool_calls) or session_events (for events). Migration log line prints when columns are dropped so the operator notices.
• Historical sessions' JSON data is gone — DROP COLUMN doesn't preserve dropped column data. Migration log makes this clear. Surface tables + session_events have all the same atoms going forward; pre-refactor(conversation-store): per-surface tables + realtime tool_call writes #1051 history was already partially recoverable from those.

🤖 Generated with Claude Code

[sonichi]

LGTM — clean redundancy cleanup after #1051's per-surface tables landed. Per #1052's analysis:

• Drops the triple-encoded sessions.events JSON column + duplicate session_events rows (event_name='user:<text>' / 'sutando:<text>' / 'tool_call:<name>') that the #1051 per-surface tables made redundant.
• Single source of truth post-merge: per-surface row in voice / phone / discord_voice tables. session_events keeps only system events (SESSION_END etc.), not utterance/tool-call duplicates.
• Now-clean diff after Maddy's rebase: 1 commit (c7b314e), +130/-49 — visible in the PR diff. Rebase resolved the stacking-on-#1051 conflict.

Per Maddy at 13:51Z. Ready for merge.