Repository navigation
Conversation
…E_OWNER PR #973 hardened the parser so `DISCORD_VOICE_OWNER=1`, `=TRUE`, `=yes`, etc. all fall through to the safe surface — only the literal lowercase `true` enables the legacy owner-mode escape hatch. Document this on the env-var bullet so anyone reading the SKILL doesn't assume the usual truthy-string shapes work. Pure docs; no code change. The Trust-boundary section already reflects the per-speaker tier model from PR #984. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
liususan091219
left a comment
There was a problem hiding this comment.
The one-line note is accurate for current main — DISCORD_VOICE_OWNER does strict-literal-true parsing (PR #973), so =1 / =TRUE / =yes correctly fall through to the safe surface, and documenting that removes a real footgun.
One thing to weigh before merging — overlap with #1017. PR #1017 removes DISCORD_VOICE_OWNER entirely, moving owner-mode into $SUTANDO_WORKSPACE/config/discord-voice.json (owner_mode + per-channel channels). The two PRs also edit the same SKILL.md region (the DISCORD_VOICE_OWNER bullet under "Optional env"), so they'll textually conflict — and if #1017 lands, this PR's added sentence documents an env var that no longer exists.
Suggested resolution, either works:
- Merge #1011 first as an interim doc fix and let #1017 supersede the whole section; or
- Close #1011 and fold the strict-parse caveat into #1017's rewritten config docs (if any
DISCORD_VOICE_OWNERback-compat shim survives there).
Not blocking — the change itself is correct — just flagging so the two don't collide. COMMENT.
— Lucy (Mac Studio bot)
|
Closing as obsolete: If a deprecation note is wanted in SKILL.md instead, that's a separate small PR pointing at the new per-channel config. |
Summary
DISCORD_VOICE_OWNERenv doc inskills/discord-voice/SKILL.md:=1,=TRUE,=yes(and any other truthy-looking string) do NOT enable owner mode — only the literal lowercasetruedoes, per PR fix(discord-voice): default DISCORD_VOICE_OWNER to false (safe) #973's strict-parse hardeningPure docs — no behavior change.
Test plan
(process.env.DISCORD_VOICE_OWNER ?? 'false') === 'true'parser atskills/discord-voice/scripts/discord-voice-server.tsmatches the doc claim (literal === comparison; onlytruepasses)🤖 Generated with Claude Code