Skip to content

docs(discord-voice): note strict-literal true parse on DISCORD_VOICE_OWNER - #1011

Closed
sonichi wants to merge 1 commit into
mainfrom
docs/discord-voice-strict-parse-note-2026-05-22
Closed

sonichi wants to merge 1 commit into
mainfrom
docs/discord-voice-strict-parse-note-2026-05-22

Conversation

@sonichi

@sonichi sonichi commented May 22, 2026

Copy link
Copy Markdown
Owner

Summary

Pure docs — no behavior change.

Test plan

  • Read updated bullet: still grammatical, still anchored on the legacy-fallback role
  • Verify the (process.env.DISCORD_VOICE_OWNER ?? 'false') === 'true' parser at skills/discord-voice/scripts/discord-voice-server.ts matches the doc claim (literal === comparison; only true passes)
  • No CI risk — single-line markdown edit

🤖 Generated with Claude Code

…E_OWNER

PR #973 hardened the parser so `DISCORD_VOICE_OWNER=1`, `=TRUE`, `=yes`, etc.
all fall through to the safe surface — only the literal lowercase `true`
enables the legacy owner-mode escape hatch. Document this on the env-var
bullet so anyone reading the SKILL doesn't assume the usual truthy-string
shapes work.

Pure docs; no code change. The Trust-boundary section already reflects the
per-speaker tier model from PR #984.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@liususan091219 liususan091219 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one-line note is accurate for current main — DISCORD_VOICE_OWNER does strict-literal-true parsing (PR #973), so =1 / =TRUE / =yes correctly fall through to the safe surface, and documenting that removes a real footgun.

One thing to weigh before merging — overlap with #1017. PR #1017 removes DISCORD_VOICE_OWNER entirely, moving owner-mode into $SUTANDO_WORKSPACE/config/discord-voice.json (owner_mode + per-channel channels). The two PRs also edit the same SKILL.md region (the DISCORD_VOICE_OWNER bullet under "Optional env"), so they'll textually conflict — and if #1017 lands, this PR's added sentence documents an env var that no longer exists.

Suggested resolution, either works:

  • Merge #1011 first as an interim doc fix and let #1017 supersede the whole section; or
  • Close #1011 and fold the strict-parse caveat into #1017's rewritten config docs (if any DISCORD_VOICE_OWNER back-compat shim survives there).

Not blocking — the change itself is correct — just flagging so the two don't collide. COMMENT.
— Lucy (Mac Studio bot)

@sonichi

sonichi commented May 23, 2026

Copy link
Copy Markdown
Owner Author

Closing as obsolete: DISCORD_VOICE_OWNER was rendered inert by #1016 / #1017 (per-channel owner-mode via workspace config). The env var now only triggers a one-shot deprecation warning (discord-voice-server.ts:161-167); its parse semantics — strict or otherwise — no longer affect runtime tier resolution. Documenting it would mislead operators into thinking it still works. Skipping.

If a deprecation note is wanted in SKILL.md instead, that's a separate small PR pointing at the new per-channel config.

@sonichi sonichi closed this May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants