[Web] Don't cancel buttons when pointer moves inside - #4100
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes web button/touchable cancellation behavior by ensuring button-role elements don’t get cancelled just due to pointer movement within bounds, while still cancelling correctly when the pointer actually leaves the element (even when pointer capture isn’t used).
Changes:
- Stop cancelling
role="button"gestures on movement distance threshold; only non-button views use movement to activate. - Add a
pointerleave-based fallback to trigger “pressed pointer left view” logic whenpointermoveno longer fires due to lack of pointer capture (e.g.role="button").
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/web/tools/PointerEventManager.ts | Uses DOM pointerleave to reliably run pressed-pointer leave handling when pointer capture isn’t used. |
| packages/react-native-gesture-handler/src/web/handlers/NativeViewGestureHandler.ts | Removes movement-distance-based cancellation for button-role views so moving inside the button doesn’t cancel the press. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
reviewed
Apr 20, 2026
m-bert
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents the buttons from being canceled when the pointer is moved inside the button.
Note that this only works with a mouse, since the browser will cancel any events with no
touchActionduring any drag gesture.Test plan
Screen.Recording.2026-04-20.at.11.55.13.mov
Screen.Recording.2026-04-20.at.11.54.55.mov
Expand