Bring back onUpdate to Native gesture - #4034
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Re-introduces TypeScript support for the onUpdate callback in the v3 Native gesture configuration by treating it as a continuous gesture config (instead of discrete), aligning the type surface with the runtime behavior.
Changes:
- Switch
NativeGestureInternalConfigfromBaseDiscreteGestureConfigtoBaseGestureConfigto re-enableonUpdateinNativeGestureConfig.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
onUpdatecallback was removed fromNativegesture config. However,Nativecan be treated as continuous gesture and having this callback might be useful.Test plan
Tested on Android on the following code: