Skip to content

fix(cms): restore GraphQL with valid policy enum options - #96

Merged
snowopsdev merged 2 commits into
mainfrom
codex/qa-20260905-lane09
Sep 5, 2026
Merged

snowopsdev merged 2 commits into
mainfrom
codex/qa-20260905-lane09

Conversation

@snowopsdev

Copy link
Copy Markdown
Owner

What Problem This Solves

Every GraphQL request failed during schema construction because the Information Gain Policy global used select values named true and false. Payload exposed those values as GraphQL enum identifiers, where those reserved names are invalid, so even unrelated authenticated queries returned an empty HTTP 500 response.

Why This Change Was Made

The policy options now use the valid names enabled and disabled. A reversible PostgreSQL enum-label migration preserves existing stored choices without rewriting rows, the runtime parser understands both new and legacy values, and a validation hook normalizes older REST and Local API clients before storage.

User Impact

The GraphQL schema builds again, authenticated queries work, and anonymous queries remain denied without exposing user data. Existing information-gain policy choices retain their meaning through the migration, including clear or unset values.

Evidence

  • Direct schema regression reproduced the GraphQL enum error before the repair and passes afterward.
  • Migration verification preserved an enabled, disabled, and null policy row through the label conversion.
  • Nine lane suites passed 164/164 tests, including 43 new collection, global, internal-create, append-only, GraphQL, and legacy-input checks.
  • Pipeline policy checks passed 37/37.
  • HTTP boundary journey passed 28/28 requests, including anonymous denial, authenticated GraphQL access, and post-logout token rejection.
  • Both workspace typechecks, scoped ESLint, and diff checks passed; owned servers stopped normally.

Rename policy options while preserving existing choices through a reversible migration and legacy API input normalization. Add schema, access-boundary, and compatibility checks for E2E-010.

Co-Authored-By: Codex <noreply@openai.com>
@snowopsdev
snowopsdev marked this pull request as ready for review September 5, 2026 03:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T04:11:27.101197Z 5392437 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1615ff9833

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Codex <noreply@openai.com>
@snowopsdev

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 5392437826

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@snowopsdev
snowopsdev merged commit d57f27c into main Sep 5, 2026
7 checks passed
@snowopsdev
snowopsdev deleted the codex/qa-20260905-lane09 branch September 5, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant