Repository navigation
fix(cms): restore GraphQL with valid policy enum options - #96
Conversation
Rename policy options while preserving existing choices through a reversible migration and legacy API input normalization. Add schema, access-boundary, and compatibility checks for E2E-010. Co-Authored-By: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1615ff9833
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What Problem This Solves
Every GraphQL request failed during schema construction because the Information Gain Policy global used select values named
trueandfalse. Payload exposed those values as GraphQL enum identifiers, where those reserved names are invalid, so even unrelated authenticated queries returned an empty HTTP 500 response.Why This Change Was Made
The policy options now use the valid names
enabledanddisabled. A reversible PostgreSQL enum-label migration preserves existing stored choices without rewriting rows, the runtime parser understands both new and legacy values, and a validation hook normalizes older REST and Local API clients before storage.User Impact
The GraphQL schema builds again, authenticated queries work, and anonymous queries remain denied without exposing user data. Existing information-gain policy choices retain their meaning through the migration, including clear or unset values.
Evidence
enabled,disabled, and null policy row through the label conversion.