fix scroll error on home page - #278
Merged
Merged
Conversation
StephenFluin
requested review from
AnushV,
PatrickAlphaC and
alexroan
as code owners
August 4, 2021 20:55
|
✔️ Deploy Preview for dreamy-villani-0e9e5c ready! 🔨 Explore the source changes: dc0b7df 🔍 Inspect the deploy log: https://app.netlify.com/sites/dreamy-villani-0e9e5c/deploys/611e827a97eadd00075b0c0d 😎 Browse the preview: https://deploy-preview-278--dreamy-villani-0e9e5c.netlify.app |
StephenFluin
force-pushed
the
stephen/fix-scroll-error
branch
from
August 19, 2021 16:09
69a431a to
a315bac
Compare
StephenFluin
force-pushed
the
stephen/fix-scroll-error
branch
from
August 19, 2021 16:10
a315bac to
dc0b7df
Compare
Contributor
Author
|
@dwightjl can you take a look? |
Contributor
Yes I listed this for our next meeting. I couldn't identify any scrolling issues with our current site. Can you describe more clearly what issue this PR is fixing? |
Contributor
Author
|
[image: image.png]
Home page has JS errors.
…On Thu, Aug 19, 2021 at 11:36 AM Dwight Lyle ***@***.***> wrote:
@dwightjl <https://github.com/dwightjl> can you take a look?
Yes I listed this for our next meeting. I couldn't identify any scrolling
issues with our current site. Can you describe more clearly what issue this
PR is fixing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIJQDHUEGLZUZIGXLAB2TT5UXJXANCNFSM5BR7ZH7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
dwightjl
approved these changes
Aug 19, 2021
Contributor
That's my lack of web development instinct showing through. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.