Skip to content

remove escape character in shell samples - #251

Closed
thisonedev wants to merge 1 commit into
mainfrom
dmitrydao/shell-fix
Closed

remove escape character in shell samples#251
thisonedev wants to merge 1 commit into
mainfrom
dmitrydao/shell-fix

Conversation

@thisonedev

Copy link
Copy Markdown

fixes #244

@netlify

netlify Bot commented Jul 22, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for dreamy-villani-0e9e5c ready!

🔨 Explore the source changes: 3ce19aa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dreamy-villani-0e9e5c/deploys/60f8fe10182bd4000844abc2

😎 Browse the preview: https://deploy-preview-251--dreamy-villani-0e9e5c.netlify.app

@StephenFluin StephenFluin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. For any [block:] style JSON, the escape characters need to stay. It's only when we move to backtick notation (which we should do for all of these examples) that you need to remove the escape characters.

For example, on enabling-https, the echo command looks right in the docs today. Feels like a lucky bug that removing the escape chars still works in those JSON examples.

@thisonedev

Copy link
Copy Markdown
Author

Closing PR. Replaced with #258

@thisonedev thisonedev closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell commands are not copy paste compatible - remove escape character

2 participants