Repository navigation
test(web-smoke): pin Home empty-fleet state in usage-strip SC-009 tests - #1573
Merged
Merged
Conversation
On an empty fleet (run-web-smoke.sh without MCPPROXY_FIXTURE_PATH) Home shows the Get started card and hides the usage strip by design (#1467), so the three Home strip tests timed out waiting for it. Wait for either anchor; on the empty state assert the strip is absent and skip.
Deploying mcpproxy-docs with
|
| Latest commit: |
46ce70e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a71d688e.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-home-strip-smoke-empty-f.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 38119280472 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./scripts/run-web-smoke.shwithoutMCPPROXY_FIXTURE_PATHfailed 3 tests: thenavigation-consistency.spec.ts:397"Home strip usage-strip-{calls,blocked,errors}" SC-009 tests each timed out waiting for the Home usage strip.Root cause: the test, not the strip. Without a fixture path the smoke fleet is empty. Since #1467 (fix-ux-residuals), Home shows the "Get started" card on an instance with no servers and hides the usage strip by design (
Home.vue:47,showGettingStarted). Tool-call history plays no part: the strip renders with zero counts whenever servers exist.Fix: the tests now wait for either the strip link or the Get started card. In the empty state they assert that no
usage-strip-*link is rendered and skip, matching the sweep's other server-dependent checks. The absence check targets the child links because Vue attribute fallthrough replaces the strip root'sdata-testwith Home'shome-usage-strip-*(found in cross-review).Verification (rebuilt with
make build, scratch ports 18896/18897)MCPPROXY_FIXTURE_PATH(CI config): all 3 strip tests pass. The strip itself works.profiles-scope.spec.ts:231(activity table overflows by 34px at 1100px) andvisual-a11y-sweep.spec.ts:663/clients corporate+dark (the orphan chip now reads "Locked … locked by credential" instead of "missing"). They are not addressed here.Reviewed by opencode
gpt-6.1-sol: round 1 found the fallthrough issue, now fixed; round 2 returned CLEAN.🤖 Generated with Claude Code