Repository navigation
feat: add Slackbot availability option to team_info - #2003
Merged
mwbrooks merged 1 commit intoOct 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
==========================================
- Coverage 84.38% 84.35% -0.03%
==========================================
Files 118 118
Lines 13812 13812
==========================================
- Hits 11655 11651 -4
- Misses 2157 2161 +4 ☔ View full report in Codecov by Harness. |
mwbrooks
added
enhancement
mwbrooks
reviewed
Oct 29, 2026
mwbrooks
left a comment
mwbrooks
left a comment
Member
There was a problem hiding this comment.
✅ Thanks @samkantor123! This looks good to me. Before approving, we are just confirming that the API details are finalized.
| self.client.token = "xoxb-coverage" | ||
| response = self.client.team_info(team="T123") | ||
| self.assertEqual({"team": "T123"}, response.req_args["params"]) | ||
| for include, encoded in [(True, "1"), (False, "0")]: |
Member
There was a problem hiding this comment.
praise: Thanks for covering the omitted, True, and False cases!
mwbrooks
approved these changes
Oct 29, 2026
mwbrooks
left a comment
mwbrooks
left a comment
Member
There was a problem hiding this comment.
✅ Thanks @samkantor123! Confirmed the API is final, so this is good to go. Appreciate the thorough tests!
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
include_slackbot_availability: Optional[bool] = NonetoWebClient.team_infoand regenerate the async and legacy clients withscripts/codegen.py.This makes the opt-in argument discoverable and typed. Existing callers can already pass it through
**kwargs, and response dictionaries already preserveteam.slackbot_availability; no response model changes are needed.Add a regression test verifying omission and true/false serialization through the existing mock Web API server. Existing
teamanddomainbehavior stays unchanged.Testing
Passed on Python 3.15: code generation, formatting, lint, mypy, and the full test suite (1,041 passed, 5 skipped).
source .venv/bin/activate ./scripts/run_validation.shCategory
tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.