Repository navigation
chore: do not deobfuscate known top level domains - #1369
Merged
Merged
Conversation
Owner
|
@jpstotz great idea! |
skylot
approved these changes
Feb 6, 2022
Collaborator
Author
|
@skylot As deobfuscation is optional and only used in a short period while loading I thought it is not necessary to keep the tld list in memory all the time. But as the list is very short it does not really make a difference, so I have adapted my PR. |
Owner
|
@jpstotz thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not deobfuscate known top level domains with 2 or 3 characters:
I noticed that common packages like
ch.qos.logback,de.greenrobot,io.jsonwebtoken... are always renamed because of length of their first level package name. As they are known top level domains I added a check to exclude all current tlds that have 2 or 3 characters.